Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-import] feat: grey out non imported columns #692

Open
wants to merge 1 commit into
base: releaseCandidate
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Feat/grey out non imported columns (#1)
* grey out non imported columns

* updated changes.md
kaustubhdapurkar authored Dec 28, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 28edd826608354416f04e99c68bf7fbb46a7ba0c
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@
- Add new options to hide buttons in popup [feature 618](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/618)
- Added an option for Data Exporter to use local browser time [feature 527](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/527) (contribution by [David Moruzzi](https://github.com/dmoruzzi))
- Add `calculated` to type column [feature 680](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/680) (contribution by [Lars Lipman](https://github.com/lrlip))
- Grey out columns that were not imported during data import [feature 507](https://github.com/tprouvot/Salesforce-Inspector-reloaded/issues/507) request by [Wintermute1974](https://github.com/Wintermute1974) (contribution by [Kaustubh Dapurkar](https://github.com/kaustubhdapurkar))

## Version 1.25

4 changes: 4 additions & 0 deletions addon/data-load.css
Original file line number Diff line number Diff line change
@@ -94,6 +94,10 @@
text-decoration-style: dotted;
}

.scrolltable-cell.skipped {
background-color: lightgrey;
}

.pop-menu {
position: absolute;
padding: 7px 0;
9 changes: 4 additions & 5 deletions addon/data-load.js
Original file line number Diff line number Diff line change
@@ -590,7 +590,7 @@ export function initScrollTable(scroller) {
if (colVisible[c] == 0) continue;
let cell = row[c];
let td = document.createElement("td");
td.className = "scrolltable-cell header";
td.className = `scrolltable-cell header ${cell.startsWith("_") ? "skipped" : ""}`;
td.style.minWidth = colWidths[c] + "px";
td.style.height = rowHeights[r] + "px";
renderCell(data, cell, td);
@@ -612,10 +612,9 @@ export function initScrollTable(scroller) {
}
let cell = row[c];
let td = document.createElement("td");
td.className = "scrolltable-cell";
if (c < headerCols) {
td.className += " header";
}
let headerRow = data.table[0];
let isColumnHeaderSkipped = headerRow[c].startsWith("_");
td.className = `scrolltable-cell ${isColumnHeaderSkipped ? "skipped" : ""} ${c < headerCols ? "header" : ""}`;
td.style.minWidth = colWidths[c] + "px";
td.style.height = rowHeights[r] + "px";
renderCell(data, cell, td);