Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker inconsistencies #182

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Fix Docker inconsistencies #182

merged 4 commits into from
Aug 14, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Aug 14, 2024

Summary

During the automated release of v0.3.0, there proved to be some inconsistencies in terms of image tagging and others. The inconsistencies fixed are listed below:

  • Switch to edge image for docker-compose.yml files
  • Alphabetize dependencies used in Dockerfile
  • Finalize change for build cache to be located in it's own package
  • Swap tokens for tagging to personal access tokens (this seemed to be the fix)
  • Ensure Docker workflows can only be run if it's not a dependabot or pre-commit-ci push to main
  • Removed unused docker.env found in the previously existing envs folder

Types of changes

What types of changes does your code introduce to Rodhaj
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

Copy link

sonarcloud bot commented Aug 14, 2024

@No767 No767 merged commit 964886a into main Aug 14, 2024
9 checks passed
@No767 No767 deleted the noelle/docker-image-fix branch August 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant