Generate error annotations when not publishing a check #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the GitHub Actions to create/update a check with annotations have multiple drawbacks, and doesn't work well in repositories with complex workflows. Create error annotations when skip publish option is set, without using the GHA REST API.
nineinchnick
force-pushed
the
surefire-report-update-check
branch
from
f3593b2
to
7c331cd
Compare
|
Tehnically we could also generate a job summary. Getting the number of executed tests might be useful since we only run tests from impacted modules in PRs. I'll do this as a follow-up. |
|
I tested this in my Trino fork, since I opened a PR with a hardcoded test failure against a branch that's using these updated actions: https://github.com/nineinchnick/trino/actions/runs/10884950374?pr=18 The annotation shows up in the summary. |
wendigo
reviewed
Sep 17, 2024
| startColumn: annotation.start_column, | ||
| endColumn: annotation.end_column | ||
| }; | ||
| core.error(annotation.message, properties); |
wendigo
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the GitHub Actions to create/update a check with annotations have
multiple drawbacks, and doesn't work well in repositories with complex
workflows. Create error annotations when skip publish option is set,
without using the GHA REST API.
This is inspired by https://github.com/mikepenz/action-junit-report/blob/main/src/annotator.ts#L39
I'll apply the same change in https://github.com/starburstdata/action-testng-report before using this in the Trino workflows.