Update tests to run on Maven 3.9 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmostly
force-pushed
the
will/maven39
branch
from
2750457
to
80dde7d
Compare
vishalya
reviewed
Aug 25, 2023
|
We should move away from testng to junit and junit jupyter like Trino |
andythsu
approved these changes
Sep 5, 2023
|
Do we want to merge this and migrate back to Junit later ? Seems like we could just use junit now .. or is there some obstacle @willmostly ? |
willmostly
force-pushed
the
will/maven39
branch
from
481ab86
to
1e31ca4
Compare
|
Updated to junit 5, @vishalya and I are going to look into the test logic to see why the Ldap tests are getting connection timeouts |
willmostly
force-pushed
the
will/maven39
branch
from
1e31ca4
to
fe816f6
Compare
mosabua
reviewed
Sep 15, 2023
gateway-ha/pom.xml
Outdated
| <artifactId>mockito-all</artifactId> | ||
| <version>1.10.19</version> | ||
| <artifactId>mockito-core</artifactId> | ||
| <version>5.3.1</version> |
There was a problem hiding this comment.
yeah - this is the only usage of Mockito, so fortunately there wasn't anything holding us back. It is needed for junit 5 compatibility
|
@willmostly - I have that test working with some minor changes on top of yours, https://github.com/vishalya/trino-gateway/commits/working_test |
willmostly
force-pushed
the
will/maven39
branch
from
0ff4820
to
ec4f981
Compare
vishalya
reviewed
Sep 18, 2023
gateway-ha/src/test/java/io/trino/gateway/ha/security/TestLbFilter.java
Outdated
Show resolved
Hide resolved
willmostly
force-pushed
the
will/maven39
branch
3 times, most recently
from
db847c2
to
f0d2b3f
Compare
willmostly
force-pushed
the
will/maven39
branch
from
f0d2b3f
to
4264fb5
Compare
vishalya
approved these changes
Sep 19, 2023
mosabua
approved these changes
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that passed on 3.6 are failing on 3.9. It looks like this is potentially due to stricter handling of NPEs. These changes define methods in the stub classes to prevent NPEs in the authentication layer.