-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix development environment configs #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome .. I will look more in detail tomorrow |
mosabua
reviewed
Sep 22, 2023
willmostly
requested changes
Sep 22, 2023
andythsu
suggested changes
Sep 22, 2023
Closed
mosabua
approved these changes
Sep 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor updates.. then ready to go.
andythsu
approved these changes
Sep 24, 2023
Chaho12
force-pushed
the
feature/jaeho.yoo/fix_dev_env
branch
from
September 24, 2023 14:34
f89f4dc
to
56b5f7e
Compare
Updated comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade docker-compose file version
start_period
option was added in file format 3.4Specify
PGUSER=trino_gateway_db_admin
in postgresql so that it doesn't use current OS user as database user name.FATAL: role "root" does not exist
Specify
PGDATABASE=trino_gateway_db
so that it doesn't use user name as DB name to access in default.FATAL: database "trino_gateway_db_admin" does not exist
Update mysql healthcheck cmd (needs pwd)
[Note] Access denied for user 'root'@'localhost' (using password: NO)
Add support for development using m1
platform: linux/amd64
so that it can download image