Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Morris surface tension model #584

Open
wants to merge 441 commits into
base: main
Choose a base branch
from

reset to original version

cfe7626
Select commit
Loading
Failed to load commit list.
Open

Implement Morris surface tension model #584

reset to original version
cfe7626
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 13, 2024 in 0s

69.08% (+0.56%) compared to f051b55

View this Pull Request on Codecov

69.08% (+0.56%) compared to f051b55

Details

Codecov Report

Attention: Patch coverage is 59.04139% with 188 lines in your changes missing coverage. Please review.

Project coverage is 69.08%. Comparing base (f051b55) to head (cfe7626).

Files with missing lines Patch % Lines
src/schemes/fluid/surface_normal_sph.jl 44.50% 96 Missing ⚠️
src/visualization/write2vtk.jl 0.00% 28 Missing ⚠️
src/schemes/fluid/surface_tension.jl 20.00% 24 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 50.00% 10 Missing ⚠️
src/schemes/fluid/fluid.jl 44.44% 10 Missing ⚠️
...rc/schemes/fluid/weakly_compressible_sph/system.jl 72.72% 6 Missing ⚠️
src/general/semidiscretization.jl 72.22% 5 Missing ⚠️
src/schemes/boundary/system.jl 87.50% 4 Missing ⚠️
src/general/system.jl 66.66% 2 Missing ⚠️
src/schemes/boundary/boundary.jl 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   68.51%   69.08%   +0.56%     
==========================================
  Files          87       90       +3     
  Lines        5406     5793     +387     
==========================================
+ Hits         3704     4002     +298     
- Misses       1702     1791      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov