Fixes #14
Merged
Fixes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
requested review from
nickray,
daringer,
szszszsz and
robin-nitrokey
robin-nitrokey
approved these changes
Jun 9, 2023
src/lib.rs
Outdated
Comment on lines
169
to
170
| // 10 => State::CancelingRequested, | ||
| // 11 => State::CancelingBuildingResponse, |
There was a problem hiding this comment.
These can now be removed too.
Reduce code duplication
The Responder never actually dealt with the intermediary stages of CancelingRequested and CancelingBuildingResponse, but could still observe them. Despite that, the loom tests still don't reach any panic
The first ordering of no operation relies on SeqCst semantics. All works with Acquire/Release semantics, so there is no reason to use the SeqCst ordering. The second ordering argument is for the failure, in which case we don't read any data, and therefore don't need any synchronization.
sosthene-nitrokey
force-pushed
the
fixes
branch
from
e658a88
to
b6fcf4b
Compare
|
This does not affect the public API, right? |
|
No, (unless you count doc(hidden) items. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the fixes from #13 but without the support for interrupts, which is not being used.
respondimplementation:Since the check of
State::BuildingResponse == self.channel.state.load(Ordering::Acquire)was distinct from theself.channel.state.store(State::Responded, …), the request could be cancelled while the response was written. 0cd5037 adds the fix and updatestests/loom.rsto trigger this case.transitionmethod.The first ordering of no operation relies on SeqCst semantics.
All works with Acquire/Release semantics, so there is no reason to use the SeqCst ordering.
The second ordering argument is for the failure, in which case we don't read any data,
and therefore doesn't need any synchronization.