Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Fixes #14

merged 6 commits into from
Jun 14, 2024

Commits on Sep 28, 2023

  1. Move transition method to the channel 

    Reduce code duplication
    @sosthene-nitrokey
    sosthene-nitrokey committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    d3d99d5 View commit details
    Browse the repository at this point in the history

  2. Simplify cancelation logic 

    The Responder never actually dealt with the intermediary stages of
CancelingRequested and CancelingBuildingResponse, but could still observe them.

Despite that, the loom tests still don't reach any panic
    @sosthene-nitrokey
    sosthene-nitrokey committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6edec7c View commit details
    Browse the repository at this point in the history

  3. Add missing branch check

    @sosthene-nitrokey
    sosthene-nitrokey committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9292f66 View commit details
    Browse the repository at this point in the history

  4. Fix respond race condition and add test for it

    @sosthene-nitrokey
    sosthene-nitrokey committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    081b807 View commit details
    Browse the repository at this point in the history

  5. Relax ordering of transition 

    The first ordering of no operation relies on SeqCst semantics.
All works with Acquire/Release semantics, so there is no reason to use the SeqCst ordering.

The second ordering argument is for the failure, in which case we don't read any data,
and therefore don't need any synchronization.
    @sosthene-nitrokey
    sosthene-nitrokey committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    15d9243 View commit details
    Browse the repository at this point in the history

  6. Remove commented-out states

    @sosthene-nitrokey
    sosthene-nitrokey committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    b6fcf4b View commit details
    Browse the repository at this point in the history