feat: attachment proof #3259
build.yml
on: pull_request
Semantic Pull Request Check
4s
Publish image
0s
Annotations
7 errors and 8 warnings
BDDTest
cannot use oidc4vp.NewAttachmentService(getHTTPClient(metricsProvider.Attachments)) (value of type *"github.com/trustbloc/vcs/pkg/service/oidc4vp".AttachmentService) as "github.com/trustbloc/vcs/pkg/service/oidc4vp".attachmentService value in struct literal: *"github.com/trustbloc/vcs/pkg/service/oidc4vp".AttachmentService does not implement "github.com/trustbloc/vcs/pkg/service/oidc4vp".attachmentService (wrong type for method GetAttachments)
|
BDDTest
cannot use oidc4vp.NewAttachmentService(getHTTPClient(metricsProvider.Attachments)) (value of type *"github.com/trustbloc/vcs/pkg/service/oidc4vp".AttachmentService) as "github.com/trustbloc/vcs/pkg/service/oidc4vp".attachmentService value in struct literal: *"github.com/trustbloc/vcs/pkg/service/oidc4vp".AttachmentService does not implement "github.com/trustbloc/vcs/pkg/service/oidc4vp".attachmentService (wrong type for method GetAttachments)
|
BDDTest
Process completed with exit code 2.
|
Checks:
pkg/service/oidc4vp/attachments.go#L68
unexported-return: exported method GetAttachmentByTypes returns unexported type []*oidc4vp.attachmentData, which can be annoying to use (revive)
|
Checks
Process completed with exit code 2.
|
UnitTest
cannot use oidc4vp.NewAttachmentService(getHTTPClient(metricsProvider.Attachments)) (value of type *"github.com/trustbloc/vcs/pkg/service/oidc4vp".AttachmentService) as "github.com/trustbloc/vcs/pkg/service/oidc4vp".attachmentService value in struct literal: *"github.com/trustbloc/vcs/pkg/service/oidc4vp".AttachmentService does not implement "github.com/trustbloc/vcs/pkg/service/oidc4vp".attachmentService (wrong type for method GetAttachments)
|
UnitTest
Process completed with exit code 2.
|
Semantic Pull Request Check
The following actions uses node12 which is deprecated and will be forced to run on node16: amannn/action-semantic-pull-request@v4. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Semantic Pull Request Check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: amannn/action-semantic-pull-request@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
BDDTest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
BDDTest
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Checks
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
UnitTest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
UnitTest
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|