Update node image versions. Label docker tag for anedot specific images #9557
Conversation
strong-code
force-pushed
the
colin/docker-fixes
branch
from
ddf8c22 to
541fa2b
Compare
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated Node.js version in Docker configuration and modified image tagging for Anedot-specific deployment, with potential deployment issues due to tag mismatch.
- Inconsistent image tags between
prod-build(anedot-twenty) andprod-run(twenty) inpackages/twenty-docker/Makefilewill cause runtime failures - Updated Node.js base image from 18.17.1-alpine to 18.20-alpine in
packages/twenty-docker/twenty/Dockerfile, maintaining compatibility with package.json requirements - Missing Anedot-specific Docker labels mentioned in PR title but not implemented in Dockerfile
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| prod-run: | ||
| @docker run -d -p 3000:3000 --name twenty twenty |
There was a problem hiding this comment.
logic: Image tag 'twenty' doesn't match the 'anedot-twenty' tag used in prod-build. This will cause prod-run to fail.
| @@ -48,7 +48,7 @@ RUN npx nx build twenty-front | |||
|
|
|||
|
|
|||
| # Final stage: Run the application | |||
| FROM node:18.17.1-alpine as twenty | |||
| FROM node:18.20-alpine as twenty | |||
|
|
|||
| # Used to run healthcheck in docker | |||
There was a problem hiding this comment.
style: tsx is installed globally but not pinned to a specific version. Consider pinning for reproducibility
Update node alpine to more recent versions. Update makefile docker tags to our internal
anedot-twentyimage tags for ECR. Also rebases on top of latest upstream changes.