Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node image versions. Label docker tag for anedot specific images #9557

Closed
wants to merge 1 commit into from
+3 −3
Closed

Update node image versions. Label docker tag for anedot specific images #9557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/twenty-docker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
prod-build:
@cd ../.. && docker build -f ./packages/twenty-docker/twenty/Dockerfile --tag twenty . && cd -
@cd ../.. && docker build -f ./packages/twenty-docker/twenty/Dockerfile --tag anedot-twenty . && cd -

prod-run:
@docker run -d -p 3000:3000 --name twenty twenty
Comment on lines 4 to 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Image tag 'twenty' doesn't match the 'anedot-twenty' tag used in prod-build. This will cause prod-run to fail.

Expand Down
4 changes: 2 additions & 2 deletions packages/twenty-docker/twenty/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Base image for common dependencies
FROM node:18.17.1-alpine as common-deps
FROM node:18.20-alpine as common-deps

WORKDIR /app

Expand Down Expand Up @@ -48,7 +48,7 @@ RUN npx nx build twenty-front


# Final stage: Run the application
FROM node:18.17.1-alpine as twenty
FROM node:18.20-alpine as twenty

# Used to run healthcheck in docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: tsx is installed globally but not pinned to a specific version. Consider pinning for reproducibility

RUN apk add --no-cache curl jq
Expand Down
Loading