-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create test and augment VoiceResponse with config param. #874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [DI-2059] default lazyloading to true
Fixes Sonar code coverage!!!
* feat: generate Twilio.ts file
Also mark as deprecated.
* [DI-2164] modify unit test to regrex expressions
* chore: drop node versions < 14
* [DI-1401] Add utili funcs to Version and property to Page
* [DI-1412] Add Cluster Test
This reverts commit cc83893.
* [DI-1412] Include Cluster Test
* chore: yeet lodash
* chore: upgrade target to es2020
* chore: touch up request validator
Fixes warning: > Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
This removes TypeScript errors for non-matching types.
* [DI-2444] add comment feature
Fixes twilio#715 If the messageBody is malformed then there will be a json parse error since the only check to allow parse is whether the body be a string or not. If we wrap the parse in a try catch, we can code a gentler response.
* [DI-2414] test: add test case to ensure done only gets called once * [DI-2414] fix: only call done once in each * [DI-2414] test: fix test cases * [DI-2414] nit: update logic for version * [DI-2414] nit: remove use strict from test cases * [DI-2414] chore: make code pretty
* Moving to Typedoc and handcrafted changes * Prettier changes
Corrects some strict Typescript issues and simplifies the implementation.
* [DI-2426] remove signature overloading
Hi @mariomui , Thanks for your PR. However, the changes are to generated code so we'll have to make changes in the generator. We have this on our internal backlog (DI-2544). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 691
#691
In this issue, a community member ask for a configuration object to be passed into VoiceResponse so they can use a simpler:
instead of the more verbose:
in order to use overrides specified in:
https://www.twilio.com/docs/usage/webhooks/webhooks-connection-overrides
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.