Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create test and augment VoiceResponse with config param. #874

Closed
wants to merge 106 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
b375d43
chore: Defaults lazyloading to true (#752)
claudiachua May 19, 2022
052f351
test: migrate to jest for unit tests (#756) (#756)
Jun 2, 2022
9aa1880
test: drop nyc (#757)
Jun 2, 2022
124fa79
feat: generate Twilio.ts file (#754)
Jun 13, 2022
014ac43
feat: generate the subdomain base classes (#769)
Jun 29, 2022
34f61d1
feat: migrate subdomain shortcuts (#752) (#770)
Jun 29, 2022
7871cb7
fix: useragent regrex unit test for RC branch (#774)
claudiachua Jul 13, 2022
0abcabf
chore: refactor exports for top-level domains (#773)
Jul 13, 2022
b4aa058
fix: correct the docker tag syntax for RCs
Jul 27, 2022
39e1c30
fix: add tsconfig and enable export assignment (#776)
Aug 2, 2022
05f55b2
Remove deprecated ConversationGrant
claudiachua Sep 8, 2022
f55e666
Remove deprecated IpMessagingGrant
claudiachua Sep 8, 2022
d413093
chore!: Remove Obsolete Client (#789)
claudiachua Sep 12, 2022
9145df2
chore!: Remove twiml deprecated methods (#788)
claudiachua Sep 13, 2022
7245ef7
chore: drop node versions < 14 (#791)
Sep 16, 2022
242eefd
feat: add support for node 18 (#794)
Sep 22, 2022
5858d38
test: upgrading nock for typescript support (#793)
Sep 23, 2022
0407d2e
chore: replace q with native promises (#796)
Hunga1 Sep 27, 2022
341f720
feat: Build pagination functions (#797)
claudiachua Oct 5, 2022
8bd7e7b
chore: sync with changes to main (#801)
Oct 12, 2022
cc83893
test: Include cluster test (#804)
claudiachua Oct 25, 2022
1ffd30a
Revert "test: Include cluster test (#804)" (#806)
claudiachua Oct 25, 2022
32ec77e
test: Include cluster test again (#807)
claudiachua Oct 25, 2022
ad59b30
chore: yeet lodash (#805)
Oct 26, 2022
7787750
chore: upgrade target to es2020 (#808)
Oct 26, 2022
fc329d6
fix: include babel-config and global install twilio for internal test…
Oct 28, 2022
16d1957
chore: generate latest with twilio-oai-generator (#803)
Oct 28, 2022
d93290e
fix: correct the subdomain names with multiple parts (#811)
Oct 28, 2022
fbab61a
fix: add missing top-level account products (#812)
Oct 31, 2022
b63847a
chore: update sorting
Oct 31, 2022
acf397d
fix: refactor for support of param names with dots (#813)
Nov 1, 2022
6451254
sync with latest release
Nov 1, 2022
6969d88
fix: support nested instance resources using the pathType (#814)
Nov 1, 2022
a2fa0f4
chore: add oauth subdomain
Nov 1, 2022
640a50a
fix: update userInfo filename casing
Nov 2, 2022
4cce57c
fix: serialize objects properly (#815)
Nov 2, 2022
65eddb6
fix: update casing for some mounts and properties (#816)
Nov 3, 2022
d7318d5
chore: pre-work for supporting multi-params
Nov 3, 2022
e50f014
chore: pre-work for supporting nested types
Nov 3, 2022
47d78a3
fix: properly serialize various parameters (#817)
Nov 4, 2022
91dbf22
fix: add missing resource names
Nov 4, 2022
89f0e29
fix: properly handle 'parent params' (#818)
Nov 4, 2022
c7d8bf2
fix: correct import syntax
Nov 4, 2022
2c423aa
chore: make everything prettier (#819)
Nov 7, 2022
f1b1e75
docs: prep for RC release
Nov 7, 2022
290397d
fix: use proper parent resource when prefix not matched (#820)
Nov 7, 2022
a948dc4
misc: publish under 'rc' tag
Nov 8, 2022
f89f179
docs: add commands to install release candidates
Nov 8, 2022
430fe8e
chore: sync up the latest TwiML changes
Nov 8, 2022
428dd5b
docs: add 4.0.0-rc upgrade guide (#822)
Nov 10, 2022
dcfc930
Update UPGRADE.md
Nov 10, 2022
fca75cc
Update UPGRADE.md
Nov 10, 2022
556dcce
chore: sync up with latest changes
Nov 10, 2022
42868dd
docs: update the year in the license
Nov 14, 2022
d015190
fix: correct the GoodData naming
Nov 16, 2022
eacb9b1
chore: sync with latest changes
Nov 16, 2022
174faed
misc: removed unused dependencies (#826)
Hunga1 Nov 18, 2022
3452c03
fix: properly generate response models when there are no instance ope…
Nov 23, 2022
e18440d
fix: give more descriptive error for accountSid init issues (#828)
Nov 28, 2022
4afdc76
docs: add client initialization section (#829)
Nov 28, 2022
e2204f2
docs: fix descriptions with special characters
Nov 29, 2022
4137da8
fix: remove unused models (#830)
Nov 29, 2022
b3dda12
fix: update Sip casing
Nov 29, 2022
3aaf199
[Librarian] Regenerated @ 262cdcd92a729094d792ceac9c0d3fcf895fea3d
twilio-dx Nov 30, 2022
ac1599a
Release 4.0.0-rc.1
twilio-dx Nov 30, 2022
10a9df3
fix: add prepublish step for compiling (#831)
Nov 30, 2022
d2d44d7
[Librarian] Regenerated @ 262cdcd92a729094d792ceac9c0d3fcf895fea3d
twilio-dx Nov 30, 2022
5b1a64c
Release 4.0.0-rc.2
twilio-dx Nov 30, 2022
3ca7396
fix: drop shortcuts for removed preview product
Dec 2, 2022
31420e3
feat: add path param validator (#834)
Dec 5, 2022
2241492
fix: update non-parent path param handling and instance properties (#…
Dec 5, 2022
aed7fda
fix: validate non-string path params (#835)
Dec 6, 2022
d7ae42a
feat: add path param validator (#836)
Dec 6, 2022
4de3300
fix: add response model for UserDefinedMessageSubscription (#837)
Dec 7, 2022
ee02e03
[Librarian] Regenerated @ 964f1611ab7481d828261f49551385a276499e30
twilio-dx Dec 14, 2022
c4d51d0
Release 4.0.0-rc.3
twilio-dx Dec 14, 2022
1466d2e
chore: Convert TwiML to typescript (#838)
claudiachua Dec 14, 2022
8345f7e
chore: rewrite hand-crafted JS files into TS files (#840)
Hunga1 Dec 15, 2022
4dcccb9
chore: removed page namespace from imports and references (#841)
Hunga1 Dec 15, 2022
a9cca90
fix: resolve page payload types (#842)
Dec 15, 2022
522d897
chore: upgrade jsonwebtoken from 8.5.1 to 9.0.0 (#847)
twilio-product-security Dec 27, 2022
0d3fd32
fix: correct many of the v2010 date property types (#843)
Dec 27, 2022
7c2d9b2
chore: touch up request validator (#849)
Dec 28, 2022
4997b21
[Librarian] Regenerated @ 51c4a5ce16a1ee0be09195af47a2ecef0f394be6
twilio-dx Dec 28, 2022
b7a2b71
Release 4.0.0-rc.4
twilio-dx Dec 28, 2022
5e93c13
chore: upgrade GitHub Actions dependencies (#851)
Dec 28, 2022
1ea326a
fix: stringify non-string path param response properties (#854)
Dec 29, 2022
ff81118
chore: add rc branch to test&deploy workflow (#858)
Dec 30, 2022
e445d22
chore: tighten up some of the types (#859)
Dec 30, 2022
799f162
docs: updated the year in the license
Jan 3, 2023
d106139
feat: Include comment in node twiml XML (#856)
claudiachua Jan 3, 2023
1508e52
fix: update SMS messaging parse error (#855)
mariomui Jan 3, 2023
b65a0af
Changes to twilio.ts file for TSDoc (#862)
rakatyal Jan 4, 2023
e8330cb
fix: done only gets called one in each (#861)
mattcole19 Jan 4, 2023
bd2ecf8
feat: add types to Twilio client (#863)
Jan 4, 2023
4f2fa0d
fix: rename the interfaces file for compilation (#868)
Jan 4, 2023
32eb740
TSDoc changes for twiml generated files (#864)
rakatyal Jan 4, 2023
d4a107e
feat: Moving to Typedoc and handcrafted changes (#865)
rakatyal Jan 4, 2023
ea2a89c
TSDoc changes for generated apis (#866)
rakatyal Jan 4, 2023
e7c3545
fix: refactor the instance implementation (#860)
Jan 4, 2023
a71071b
fix: correct the lazy-load typing in the Twilio client (#870)
Jan 4, 2023
eb36bf8
fix: set the correct item type for the transform function (#871)
Jan 5, 2023
92eaef5
chore: set strict mode in tsconfig (#853)
Jan 5, 2023
40ed6a5
chore: Remove signature overloading (#872)
claudiachua Jan 5, 2023
d0f5f2e
[DI-2443] chore: Use Record type (#873)
claudiachua Jan 5, 2023
6b7e23a
Create test and augment VoiceResponse with config param.
mariomui Jan 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
],
"quotes": [
2,
"single"
"double"
],
"indent": [
2,
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/pr-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@ jobs:
name: Validate title
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v4
- uses: amannn/action-semantic-pull-request@v5
with:
types: chore docs fix feat test
types: |
chore
docs
fix
feat
misc
test
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
26 changes: 18 additions & 8 deletions .github/workflows/test-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches: [ '*' ]
tags: [ '*' ]
pull_request:
branches: [ main ]
branches: [ main, 4.0.0-rc ]
schedule:
# Run automatically at 8AM PST Monday-Friday
- cron: '0 15 * * 1-5'
Expand All @@ -17,22 +17,32 @@ jobs:
timeout-minutes: 20
strategy:
matrix:
node: [ 6, 8, 10, 12, 14, 16, lts/* ]
node: [ 14, 16, 18, lts/* ]
steps:
- name: Checkout twilio-node
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Set up Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}

- run: npm install
- name: Run Unit Tests
run: npm run ci

- name: Run Cluster Tests
if: (!github.event.pull_request.head.repo.fork)
env:
TWILIO_ACCOUNT_SID: ${{ secrets.TWILIO_ACCOUNT_SID }}
TWILIO_API_KEY: ${{ secrets.TWILIO_CLUSTER_TEST_API_KEY}}
TWILIO_API_SECRET: ${{ secrets.TWILIO_CLUSTER_TEST_API_KEY_SECRET }}
TWILIO_FROM_NUMBER: ${{ secrets.TWILIO_FROM_NUMBER }}
TWILIO_TO_NUMBER: ${{ secrets.TWILIO_TO_NUMBER }}
run: npm run cluster

- name: SonarCloud Scan
if: ${{ (github.event_name == 'pull_request' || github.ref_type == 'branch') && matrix.node == 'lts/*' && !github.event.pull_request.head.repo.fork }}
uses: SonarSource/sonarcloud-github-action@master
Expand All @@ -47,19 +57,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout twilio-node
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Set up Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: lts/*

- run: npm install

- name: Login to Docker Hub
uses: docker/login-action@v1
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_AUTH_TOKEN }}
Expand All @@ -79,7 +89,7 @@ jobs:
- name: Publish to NPM
run: |
npm config set //registry.npmjs.org/:_authToken ${NODE_AUTH_TOKEN}
npm publish --ignore-scripts
npm publish --ignore-scripts --tag rc
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

Expand Down
9 changes: 6 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### Logs ###
### Logs ###
logs
*.log

Expand All @@ -14,13 +14,13 @@ pids
node_modules

### Test coverage ###
spec/coverage
coverage

### Custom ignores ###
config.js
.idea

### jsdoc dir ###
### typedoc dir ###
docs

### ide / editors ###
Expand All @@ -29,3 +29,6 @@ docs
### Libraries don't need locks files ###
yarn.lock
package-lock.json

**/.openapi-generator*
dist
2 changes: 1 addition & 1 deletion .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"newcap": true,

// Enforce use of single quotation marks for strings.
"quotmark": "single",
"quotmark": "double",

// Enforce placing 'use strict' at the top function scope
"strict": true,
Expand Down
7 changes: 7 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.github
coverage
dist

babel.config.js
*.md
*.json
Loading