Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache tests #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add cache tests #209

wants to merge 1 commit into from

Conversation

masklinn
Copy link
Contributor

@masklinn masklinn commented Mar 28, 2024 •
edited
Loading

No description provided.

@masklinn masklinn changed the title Add test to ensure backfilling results does not lead to evictions Add cache tests Mar 28, 2024
@masklinn
Add test to ensure backfilling results does not lead to evictions
0b91ef3 
Partial results are back-filled (new domains added) by re-setting them
in the cache. With a sufficiently incorrect implementation, the cache
can evict entries on that occasion even though it does not need
to (because we're replacing an existing entry).

Exactly that should have been fixed by ua-parser#204, but was not tested at the
time.

Fixes ua-parser#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@masklinn