Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache tests #209

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add cache tests #209

merged 1 commit into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. Add test to ensure backfilling results does not lead to evictions 

    Partial results are back-filled (new domains added) by re-setting them
in the cache. With a sufficiently incorrect implementation, the cache
can evict entries on that occasion even though it does not need
to (because we're replacing an existing entry).

Exactly that should have been fixed by ua-parser#204, but was not tested at the
time.

Fixes ua-parser#199
    @masklinn
    masklinn committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ef6ff42 View commit details
    Browse the repository at this point in the history