Rh/make access consistent #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just selectively hide Edit button/link (when already editing)
just for key and access
follows pattern of key serials
jSylvestre
reviewed
Oct 4, 2023
| <div className='row justify-content-between'> | ||
| <h3>Equipment Details</h3> | ||
| <div className='row justify-content-between'> | ||
| <h3>Equipment Details</h3> |
There was a problem hiding this comment.
I don't know that this is needed if we are creating a new equipment.
It has the Create New Equipment title when we do that.
jSylvestre
requested changes
Oct 4, 2023
instead of doing weird transformations on the frontend
jSylvestre
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry this one is so long! there was a lot to do to get it in line with the rest of our code. lots of state stuff in react–i don't expect that will be easy to follow reading but i tried to make it as clear as i could. if you could test and see if you find bugs on the /access/list as well as /person/details that would be great
makes access components match the pattern of other assets.
adds details modal for individual access assignments, in same pattern as key serials
makes 'em pretty
removes nested/recursive access state–at most,
access.assignments[0].accesswill be populated, instead ofaccess.assignments[0].access.assignments[]...when on /access/ (
AccessContainer) we will haveaccesswith fully populated.assignments(which will not have a nested access)when on /people/ (
AccessAssignmentContainer) we will haveassignments[]with a populated.access(which will not have nested assignments)-when on /people/ (
AccessAssignmentContainer, callingaccess/listAssigned, we only pull the assignments for that person, and passnumberOfAssignmentsfor the list to usefixes a lot of small bugs, bad handling of state, clarifies names
known weird/less than ideal behavior
this is because in AccessController, we do not pass back the accesses, soassignments.lengthon the frontend is wrong. could pass back all the assignments (seems unnecessary), could add a property ofnumberOfAssignments, could just delete the column in the list, or just do nothing about it.- still have some nested state under person details, but intending to fix this next