Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rh/make access consistent #1327

Merged
merged 31 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7a78aa3
add AccessAssignmentEditValues
laholstege Sep 20, 2023
adfdec7
start of correcting access pattern: revoke
laholstege Sep 20, 2023
e687abf
fixing/clarifying names
laholstege Sep 20, 2023
0ed142a
rename things, follow pattern for other assets
laholstege Sep 20, 2023
a15869e
revoke modal
laholstege Sep 27, 2023
1e8b1eb
clear up and consistent naming
laholstege Sep 27, 2023
2f83192
always show '[Asset] Details' header in EditValues
laholstege Sep 27, 2023
fc0fc8d
make Details inside card (not modal) consistent
laholstege Sep 27, 2023
8204244
clearer name
laholstege Sep 29, 2023
f3f80f6
cleanup
laholstege Sep 29, 2023
fc20819
more cleaning up naming
laholstege Sep 29, 2023
7b13f7c
create AccessAssignmentDetails modal
laholstege Sep 29, 2023
fbcc2b8
consistency in AccessAssignmentTable, fix expiration date filter
laholstege Sep 29, 2023
9e1b91b
UpdateAccessAssignment modal pattern
laholstege Sep 29, 2023
31af5d5
format expiration date on assignments properly
laholstege Sep 29, 2023
ebb0c2f
remove AccessAssignmentCard, AccessModal, no table on access details
laholstege Sep 29, 2023
fec9da2
dont edit access except from access/details
laholstege Sep 29, 2023
c421727
dont need to render children
laholstege Sep 29, 2023
ca8c303
fix state updating, other bugs
laholstege Sep 29, 2023
47a7a19
bugs, rename
laholstege Sep 29, 2023
69a10e4
cleanup
laholstege Sep 30, 2023
bfc2e45
if on access details, use those values instead of assignment.access
laholstege Oct 3, 2023
3a37bef
naming clarity
laholstege Oct 3, 2023
880151b
fix nested/recursive state
laholstege Oct 3, 2023
57d666c
only send used info for access/list, don't send nested access data
laholstege Oct 3, 2023
0aaa7e2
wont happen but might as well
laholstege Oct 3, 2023
961ffaf
fix link
laholstege Oct 3, 2023
2ccdc6a
need this (for now?)
laholstege Oct 4, 2023
792056d
generate exact data we want on backend
laholstege Oct 4, 2023
9226069
we don't edit except on access/details
laholstege Oct 4, 2023
737b29f
clean up frontend state
laholstege Oct 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Loading
Loading