Include number of unprocessed payloads in the error message #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is also no need to emit message for each unprocessed payload because when we process them we batch together into a single message so the delay is same for all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
If the queue is completely stopped and the number of unprocessed payloads building up then the current error message cannot convey that so include the payload count in the error message.
There is also no need to emit message for each unprocessed payload because when we process them we batch together into a single message so the delay is same for all.
Note: We also prioritize sending SPIRE messages, as in before looking to batch unprocessed payloads we check if we are awaiting reply or any new messages from SPIRE that need sending. If they are all concluded then only we continue. This means during busy times then payload count can increase for a period and it is expected but should get cleared as the traffic subsides.