-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make inclusive language truly inclusive #537
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cc: @mathiasbynens (not sure who the relevant people would be but you seem to be an active maintainer so apologies) |
@RReverser and @surma are maintaining v8.dev. Could you PTAL? |
I like your additions, @Nytelife26. I would ask that you not remove “allowlist” et al from the list, tho. For English resources, they are completely valid and have somewhat become an industry-standard as replacements for whitelist/blacklist. Happy to merge afterwards :) |
For English resources for native speakers that understand the language fluently, yes. The entire point here is accessibility. They should not become the industry standard because they are unsuitable replacements. See a statement I authored for more information on that, and come back with your verdict. Do not let popularity be a reason, though - the amount of people doing something does not change its value. |
The industry is increasingly adopting “allowlist” and “blocklist”, despite the shortcomings you correctly point out. I worry that if we remove any appearance from “allowlist” and “blocklist” from the table, that people who are used to these terms are now confused because they don’t appear at all. How do you envision that being handled? To that extent, we need to at least consider the relative popularity of these terms. I see your point and I like your suggestions, but I don’t decide what is and is not popular/commonly used in the industry, which is why I am trying to get your point reflected without increasing confusion. |
It may be wise to link to an external resource on why we have not included them on viable suggestions, perhaps such as the links I have provided before and maybe a brief explanation then. If you want me to implement that into this pull request, I can - just make sure you inform me to what extent, because I don't want to go overboard by accident. |
Following discussion with others from the inclusive naming initiative, it seems that It:
On point 3: include: [a, b, c]
exclude: [a, b, c] That's quite a common configuration pattern, and it lines up nicely with inclusion / exclusion list. Thoughts on this, anyone? |
I don't really see the value in excluding something from the list of suggested alternatives, especially if such alternatives are indeed already used in the wild. If any of the proposed alternatives don't work for a particular project, they can always choose another one. |
Because we shouldn't be suggesting those "alternatives", if they can even be called that since they are not viable. They are more harmful than beneficial, as we have stated, for many reasons - and as such, there is no reason to use them, especially when there are better alternatives. |
As far as I understand, the main reason is usage in other languages. As non-native English speaker, I appreciate that concern but terminology (or words in general) by design don't map 1:1 between different languages, and I assume that other languages would have their own tables. This table is in English and is describing alternatives used in English language, and since those words are already used in the wild, removing them is worse and would cause more confusion than keeping. |
Terminology doesn't map 1:1, sure. But there are no translations for such words. Not to mention they don't even make sense in their language of origin - blocklist, denylist, et cetera, are not valid in English. They are less clear, they are invalid, they do not translate well, and others. I would implore you to read the statement I linked to in this pull request if you need any further reasoning.
That's why I proposed adding a note below the table as to why certain examples were omitted, so we can explain the decision or link to other resources. Objectively, the present alternatives are not sufficient, and if we have the opportunity to use better, as engineers, we should steer for the better choice. |
I understand your point and I want to add your additions. However, we can’t just remove terms, as we are also trying to align with the Inclusive Chromium Code guidelines, for example. Please add the removed terms back to the table so we can merge this. |
That defeats the entire purpose of the pull request. The point is these terms do more harm than good. If I must make a pull request there too prior to this so things are consistent, I will, but I'm not doing half a job here and leaving this to continue happening. If I have to explain why these terms are not present in the document, that's fine - but I will continue to drive this point until I am either proven wrong or people begin to realize the situation. Thank you for understanding, and I appreciate that you want to work with me here rather than against me, but I simply cannot drop the movement behind this just because "standards". I have discussed with members of other projects, including employees of IBM, and further discussion is in progress. If you wish to participate, you may do so here. If not, I'll keep going until this is all resolved :) Once again, thank you. I appreciate your time and consideration. Edit: |
Status, anyone? |
I can not really change anything from my last statement. I don’t control the Chromium Code guidelines and don’t know who has the power to change them. I am assuming there is a whole lot of process involved. I respect your willingness to metaphorically die on this hill, but I won’t be able to merge this unless the previous terms get added back in. |
I can not really change anything from my last statement. I don’t
control the Chromium Code guidelines and don’t know who has the power
to change them. I am assuming there is a whole lot of process involved.
There most likely is. And that's what I'll do. It seems to me that they
don't accept pull requests from GitHub, much like v8 itself, so I'll
have to do some more investigation on their Google-hosted source and
make the relevant communications in any mailing lists.
|
Found it. I am unable to post on the issues tracker for the Chromium project, including for the respective issues, so if someone could forward the following message via issue or contact on my behalf (the file is located at
Thank you in advance. |
I’d recommend opening a new issue instead and reference that one |
I’d recommend opening a new issue instead and reference that one
I tried, wouldn't let me as aforementioned unfortunately, which is why
I'm asking if a Googler can assist me with making this happen :)
|
The issue tracker is open to the public. You can create a new issue via crbug.com/new. |
Turns out it allowed me to today. If anyone wants to participate or follow the discussion, here |
The lack of engagement with the Chromium issue is, to say the least, disappointing. I'd like to hope that an organization like Google wouldn't just It has become evident that these changes were made for virtue signalling and nothing more. I'll be working closely with the INI, now, until this gains some actual internal attention from a Chromium team member - because plenty of them are interested in avoiding exclusion, but none of them are interested in engineering a real solution. |
While "blocklist" / "denylist" and "allowlist" / "grantlist" or other alternatives are quite commonly proposed, they are neglecting something - English is not the only language spoken on our Earth. In many languages, these fabricated alternatives have no direct translations.
For instance, Spanish. None of those alternatives have translations that make sense. Not to mention that "whitelist" and "blacklist" are already inaccessible in those languages due to their rarity. The most commonly used phrasing is, for instance, "list of blocked users" or "blocked user list".
We need to be mindful of this when creating guidelines for inclusivity. We need to be TRULY inclusive, and considerate of those that come from foreign backgrounds, otherwise, you are actively making the terminology less accessible to more people than you are helping.
This is not to create a flame or attack anyone on the V8 development team. I just truly believe that this hasn't been considered enough, and I do not wish to see the second wave of realization when people wake up to the fact that many people from other linguistic backgrounds will struggle to understand these alternatives. Software engineering should be accessible to all, no matter the abstract features of their background.