Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive parameters from Derive functions #1110

Merged
merged 2 commits into from
Oct 6, 2024

Remove m_Functor from VisitorBase since it is already stored in the d…

9fc62a4
Select commit
Loading
Failed to load commit list.
Merged

Remove excessive parameters from Derive functions #1110

Remove m_Functor from VisitorBase since it is already stored in the d…
9fc62a4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2024 in 1s

94.21% (-0.03%) compared to 2e5560e, passed because coverage increased by 0.06% when compared to adjusted base (94.15%)

View this Pull Request on Codecov

94.21% (-0.03%) compared to 2e5560e, passed because coverage increased by 0.06% when compared to adjusted base (94.15%)

Details

Codecov Report

Attention: Patch coverage is 99.28058% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.21%. Comparing base (2e5560e) to head (9fc62a4).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
lib/Differentiator/HessianModeVisitor.cpp 98.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
- Coverage   94.24%   94.21%   -0.03%     
==========================================
  Files          55       48       -7     
  Lines        8447     8131     -316     
==========================================
- Hits         7961     7661     -300     
+ Misses        486      470      -16     
Files with missing lines Coverage Δ
...clude/clad/Differentiator/BaseForwardModeVisitor.h 33.33% <ø> (ø)
include/clad/Differentiator/HessianModeVisitor.h 100.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 97.22% <ø> (-0.96%) ⬇️
include/clad/Differentiator/VisitorBase.h 100.00% <ø> (ø)
lib/Differentiator/BaseForwardModeVisitor.cpp 98.73% <100.00%> (+0.60%) ⬆️
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/ReverseModeForwPassVisitor.cpp 98.74% <100.00%> (-0.03%) ⬇️
lib/Differentiator/ReverseModeVisitor.cpp 95.45% <100.00%> (-2.33%) ⬇️
lib/Differentiator/HessianModeVisitor.cpp 99.51% <98.73%> (-0.03%) ⬇️

... and 33 files with indirect coverage changes

Files with missing lines Coverage Δ
...clude/clad/Differentiator/BaseForwardModeVisitor.h 33.33% <ø> (ø)
include/clad/Differentiator/HessianModeVisitor.h 100.00% <ø> (ø)
include/clad/Differentiator/ReverseModeVisitor.h 97.22% <ø> (-0.96%) ⬇️
include/clad/Differentiator/VisitorBase.h 100.00% <ø> (ø)
lib/Differentiator/BaseForwardModeVisitor.cpp 98.73% <100.00%> (+0.60%) ⬆️
lib/Differentiator/DerivativeBuilder.cpp 100.00% <100.00%> (ø)
lib/Differentiator/ReverseModeForwPassVisitor.cpp 98.74% <100.00%> (-0.03%) ⬇️
lib/Differentiator/ReverseModeVisitor.cpp 95.45% <100.00%> (-2.33%) ⬇️
lib/Differentiator/HessianModeVisitor.cpp 99.51% <98.73%> (-0.03%) ⬇️

... and 33 files with indirect coverage changes