Fix CI errors and unittest compile error on certain compiler versions #411
Conversation
Currently leads to CI errors in the vibe.d repository, because 2.096.1 hasn't been tested here.
s-ludwig
force-pushed
the
fix_unittest_error
branch
from
b33e561
to
21f8b31
Compare
Ensures that the close operation has finished before returning from the destructor in order to ensure the owning thread doesn't terminate prematurely, resulting in a crash. This fixes Windows CI failures.
|
What's the |
|
If you can provide me a command line example of compilation and the error message, I can advise. |
|
I think it was with dub-registry where I had consistent unresolved symbol errors for all methods that used simple |
|
Okay, I see. I had a quick look, but missed the obvious possibility of |
Avoids relying on closing the stream through RAII, which acts worse in terms of error reporting in the presence of in-flight exceptions.
s-ludwig
changed the title
Otherwise leads to linker errors when building together with other code that uses `in` parameters. See also vibe-d/vibe-core#411
Otherwise leads to linker errors when building together with other code that uses `in` parameters. See also vibe-d/vibe-core#411
Closing of the file stream must only be done when the last reference gets destroyed. Note that this requires an API addition in eventcore, which is why the code has been wrapped in a static if.
Fix a regression introduced by #411
Affects the CI of the vibe.d repository