Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI errors and unittest compile error on certain compiler versions #411

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Fix CI errors and unittest compile error on certain compiler versions #411

merged 5 commits into from
Sep 11, 2024

Commits on Sep 10, 2024

  1. Fix unit test compile error on certain intermediate versions of DMD. 

    Currently leads to CI errors in the vibe.d repository, because 2.096.1 hasn't been tested here.
    @s-ludwig
    s-ludwig committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    371efd8 View commit details
    Browse the repository at this point in the history

  2. Avoid using "in" parameter to avoid linker error caused by compiler bug.

    @s-ludwig
    s-ludwig committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    21f8b31 View commit details
    Browse the repository at this point in the history

  3. Comment out the libasync configuration to follow suit with eventcore.

    @s-ludwig
    s-ludwig committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e1358b8 View commit details
    Browse the repository at this point in the history

  4. Make RAII style cleanup of FileStream more robust. 

    Ensures that the close operation has finished before returning from the destructor in order to ensure the owning thread doesn't terminate prematurely, resulting in a crash. This fixes Windows CI failures.
    @s-ludwig
    s-ludwig committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9b68d42 View commit details
    Browse the repository at this point in the history

  5. Explicitly close the output stream in SyslogLogger. 

    Avoids relying on closing the stream through RAII, which acts worse in terms of error reporting in the presence of in-flight exceptions.
    @s-ludwig
    s-ludwig committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e871fbe View commit details
    Browse the repository at this point in the history