Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialize-with-vt-dba-tcp flag to enable TCP/IP connection access to the underlying MySQL instance #15354

Merged

Conversation

yoheimuta
Copy link
Contributor

@yoheimuta yoheimuta commented Feb 26, 2024

Description

This PR adds initialize-with-vt-dba-tcp flag to vttestserver. If this flag is enabled, MySQL will be initialized with an additional user named vt_dba_tcp, who will have access via TCP/IP connection. The default value is false.

Related Issue(s)

Fixes #15267

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

…nnection access to the underlying MySQL instance

Signed-off-by: Yohei Yoshimuta <[email protected]>
Copy link
Contributor

vitess-bot bot commented Feb 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 26, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 65.42%. Comparing base (f82fb7c) to head (6f5e853).
Report is 36 commits behind head on main.

Files Patch % Lines
go/vt/vttest/toxiproxyctl.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15354      +/-   ##
==========================================
- Coverage   67.45%   65.42%   -2.03%     
==========================================
  Files        1560     1561       +1     
  Lines      193203   193605     +402     
==========================================
- Hits       130324   126670    -3654     
- Misses      62879    66935    +4056     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: vttestserver and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 26, 2024
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yoheimuta yoheimuta force-pushed the support-vttestserver-dba_tcp_user branch from 048370e to 6f5e853 Compare February 27, 2024 06:35
@GuptaManan100 GuptaManan100 merged commit 69604ed into vitessio:main Feb 27, 2024
102 checks passed
@yoheimuta yoheimuta deleted the support-vttestserver-dba_tcp_user branch February 28, 2024 01:39
@deepthi deepthi changed the title Add initialize_with_vt_dba_tcp flag to enable TCP/IP connection access to the underlying MySQL instance Add initialize-with-vt-dba-tcp flag to enable TCP/IP connection access to the underlying MySQL instance Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: vttestserver Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Enable TCP/IP Connection Access to the Underlying MySQL Instance in vttestserver
3 participants