-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initialize-with-vt-dba-tcp flag to enable TCP/IP connection access to the underlying MySQL instance #15354
Add initialize-with-vt-dba-tcp flag to enable TCP/IP connection access to the underlying MySQL instance #15354
Conversation
…nnection access to the underlying MySQL instance Signed-off-by: Yohei Yoshimuta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15354 +/- ##
==========================================
- Coverage 67.45% 65.42% -2.03%
==========================================
Files 1560 1561 +1
Lines 193203 193605 +402
==========================================
- Hits 130324 126670 -3654
- Misses 62879 66935 +4056 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Yohei Yoshimuta <[email protected]>
048370e
to
6f5e853
Compare
Description
This PR adds
initialize-with-vt-dba-tcp
flag to vttestserver. If this flag is enabled, MySQL will be initialized with an additional user namedvt_dba_tcp
, who will have access via TCP/IP connection. The default value is false.Related Issue(s)
Fixes #15267
Checklist
Deployment Notes