-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ZService to functions #93
base: master
Are you sure you want to change the base?
Conversation
Covers DB operation and handling malformed entries.
Attempt to placate AppVeyor, which fails this test every time.
Will only run if DB file does not exist, which will reduce/remove locking problem for testing.
Tests work fine locally and on the source branch, so I'll try to work out what the issue is... |
@theaquamarine would you be interested in becoming a maintainer? I will continue to work on the project myself too, because I use it every day, but I wanted to give you write access to the repo and the powershellgallery so you can make release. If that's something that you would be interested in. |
I'd love to, thanks! Hopefully I can help keeping it useful and easy to use! |
Sweet! Done. I seen that you are pretty proficient with git. Git hygiene (clear commits, easy to read history) is my pet peeve.
|
I do, yes - same username. Absolutely agree on the git hygiene, I'll do my best to keep everything neat and tidy. Mess stays in development branches. Thanks again! |
Did this get any further? |
Get rid of the service and references to it and convert its methods to functions, since a service is no longer used. Also adds a bunch of tests for
ZLocation.Service
.ZLocation.Storage
is now a fairly thin wrapper around functions inZLocation.Service
, so going forward it'd probably make sense to merge the two.