Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ZService to functions #93

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Convert ZService to functions #93

wants to merge 9 commits into from

Commits on Sep 29, 2019

  1. Add tests for ZLocation.Service 

    Covers DB operation and handling malformed entries.
    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    b48f31f View commit details
    Browse the repository at this point in the history

  2. Manually close database connection before cleaning 

    Attempt to placate AppVeyor, which fails this test every time.
    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    7dc7757 View commit details
    Browse the repository at this point in the history

  3. Convert db entry removal to function

    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    5a63912 View commit details
    Browse the repository at this point in the history

  4. Convert db entry update to function

    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    0d92a41 View commit details
    Browse the repository at this point in the history

  5. Convert db entry retrieval to function

    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    f57a526 View commit details
    Browse the repository at this point in the history

  6. Remove service bits and references to a service

    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    5f2f013 View commit details
    Browse the repository at this point in the history

  7. Move db setup and migration into function 

    Will only run if DB file does not exist, which will reduce/remove
locking problem for testing.
    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    c2dfe2c View commit details
    Browse the repository at this point in the history

  8. Uppercase properties on Location

    @theaquamarine
    theaquamarine committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    e2ccb5c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. Remove the Malformed Entries tests

    @theaquamarine
    theaquamarine committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    0e7622e View commit details
    Browse the repository at this point in the history