Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ZService to functions #93

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

theaquamarine
Copy link
Collaborator

Get rid of the service and references to it and convert its methods to functions, since a service is no longer used. Also adds a bunch of tests for ZLocation.Service.

ZLocation.Storage is now a fairly thin wrapper around functions in ZLocation.Service, so going forward it'd probably make sense to merge the two.

@theaquamarine
Copy link
Collaborator Author

Tests work fine locally and on the source branch, so I'll try to work out what the issue is...

@vors
Copy link
Owner

vors commented Oct 4, 2019

@theaquamarine would you be interested in becoming a maintainer? I will continue to work on the project myself too, because I use it every day, but I wanted to give you write access to the repo and the powershellgallery so you can make release. If that's something that you would be interested in.

@theaquamarine
Copy link
Collaborator Author

I'd love to, thanks! Hopefully I can help keeping it useful and easy to use!

@vors
Copy link
Owner

vors commented Oct 11, 2019

Sweet! Done.
Do you have ps gallery account? I will add you as maintainer there as well.

I seen that you are pretty proficient with git.

Git hygiene (clear commits, easy to read history) is my pet peeve.
I'd very much appreciate, if you follow these guidelines:

  • Keep master clean and free from merges
  • Use rebase and squash button for PR merges
  • create tags for releases
  • write good commit messages and changelog entrances

@theaquamarine
Copy link
Collaborator Author

I do, yes - same username.

Absolutely agree on the git hygiene, I'll do my best to keep everything neat and tidy. Mess stays in development branches.

Thanks again!

@princemaple
Copy link

Did this get any further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants