Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't stringify custom facts; require rspec-puppet-facts 3.x #131

Closed
wants to merge 3 commits into from
Closed

don't stringify custom facts; require rspec-puppet-facts 3.x #131

wants to merge 3 commits into from

Commits on May 24, 2024

  1. dont stringify custom facts 

    rspec-puppet-facts has an option to stringify all facts:

https://github.com/voxpupuli/rspec-puppet-facts/blob/fd600001c1cc9cb0bd2522188f4a8feb15f7cf40/lib/rspec-puppet-facts.rb#L176

But this is called *after* our facts are added:

https://github.com/voxpupuli/rspec-puppet-facts/blob/fd600001c1cc9cb0bd2522188f4a8feb15f7cf40/lib/rspec-puppet-facts.rb#L173

That means that voxpupuli-test doesn't need to care how
RSpec.configuration.facterdb_string_keys is set. rspec-puppet-facts deal
with it afterwards.
    @bastelfreak
    bastelfreak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    452a649 View commit details
    Browse the repository at this point in the history

  2. rspec-puppet-facts: Require 3.x

    @bastelfreak
    bastelfreak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d47c28b View commit details
    Browse the repository at this point in the history

  3. facterdb: return all fact keys as strings

    @bastelfreak
    bastelfreak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a427188 View commit details
    Browse the repository at this point in the history