don't stringify custom facts; require rspec-puppet-facts 3.x #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspec-puppet-facts has an option to stringify all facts: https://github.com/voxpupuli/rspec-puppet-facts/blob/fd600001c1cc9cb0bd2522188f4a8feb15f7cf40/lib/rspec-puppet-facts.rb#L176 But this is called *after* our facts are added: https://github.com/voxpupuli/rspec-puppet-facts/blob/fd600001c1cc9cb0bd2522188f4a8feb15f7cf40/lib/rspec-puppet-facts.rb#L173 That means that voxpupuli-test doesn't need to care how RSpec.configuration.facterdb_string_keys is set. rspec-puppet-facts deal with it afterwards.
bastelfreak
changed the title
bastelfreak
added
backwards-incompatible
and removed
bug
|
tested at voxpupuli/puppet-example#51 |
ekohl
requested changes
May 24, 2024
|
everything that rspec-puppet-facts returns in the end are strings. You can see that here: https://github.com/voxpupuli/puppet-example/actions/runs/9227133359/job/25388427471?pr=51 custom facts are always added as symbols and depending on |
ekohl
reviewed
May 24, 2024
| @@ -71,8 +71,7 @@ def add_stdlib_facts | |||
| # Rough conversion of grepping in the puppet source: | |||
| # grep defaultfor lib/puppet/provider/service/*.rb | |||
| add_custom_fact :service_provider, ->(_os, facts) do | |||
| os = RSpec.configuration.facterdb_string_keys ? facts['os'] : facts[:os] | |||
There was a problem hiding this comment.
If we set facterdb_string_keys to true, this must be facts['os']. Otherwise the whole setting doesn't make sense. IMHO it's a bug.
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
May 24, 2024
This is the result of some poking in voxpupuli/voxpupuli-test#131 and voxpupuli/voxpupuli-test#132 (comment)
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
May 24, 2024
This is the result of some poking in voxpupuli/voxpupuli-test#131 and voxpupuli/voxpupuli-test#132 (comment) Tested in: voxpupuli/puppet-example#54
kenyon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-puppet-facts has an option to stringify all facts:
https://github.com/voxpupuli/rspec-puppet-facts/blob/fd600001c1cc9cb0bd2522188f4a8feb15f7cf40/lib/rspec-puppet-facts.rb#L176
But this is called after our facts are added:
https://github.com/voxpupuli/rspec-puppet-facts/blob/fd600001c1cc9cb0bd2522188f4a8feb15f7cf40/lib/rspec-puppet-facts.rb#L173
That means that voxpupuli-test doesn't need to care how RSpec.configuration.facterdb_string_keys is set. rspec-puppet-facts deal with it afterwards.