require rspec-puppet-facts 5.x; drop legacy facts support #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
May 24, 2024
This is the result of some poking in voxpupuli/voxpupuli-test#131 and voxpupuli/voxpupuli-test#132 (comment)
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
May 24, 2024
This is the result of some poking in voxpupuli/voxpupuli-test#131 and voxpupuli/voxpupuli-test#132 (comment) Tested in: voxpupuli/puppet-example#54
bastelfreak
force-pushed
the
foo2
branch
2 times, most recently
from
d91eef2
to
231f7bf
Compare
bastelfreak
changed the title
bastelfreak
force-pushed
the
foo2
branch
2 times, most recently
from
ea0bde3
to
39fb9c9
Compare
bastelfreak
added a commit
to bastelfreak/puppet-collectd
that referenced
this pull request
Jul 8, 2024
Test for voxpupuli/voxpupuli-test#132. the collectd module has also stringified facts enabled (see .sync.yml).
bastelfreak
added
backwards-incompatible
and removed
enhancement
rspec-puppet-facts uses FacterDB 3, which removed legacy facts.
bastelfreak
changed the title
traylenator
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-puppet-facts uses FacterDB 3, which removed legacy facts.