Add support for PostgreSQL 15 and 16 on Exoscale #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
psql/exoscale_version
branch
from
7c531f3
to
fdca205
Compare
TheBigLee
requested review from
a team,
Kidswiss,
wejdross and
zugao
and removed request for
a team
zugao
reviewed
Aug 7, 2024
| @@ -58,11 +58,11 @@ type ExoscalePostgreSQLParameters struct { | |||
| type ExoscalePostgreSQLServiceSpec struct { | |||
| ExoscaleDBaaSServiceSpec `json:",inline"` | |||
|
|
|||
| // +kubebuilder:validation:Enum="14" | |||
| // +kubebuilder:default="14" | |||
| // +kubebuilder:validation:Enum="14";"15";"16" | |||
There was a problem hiding this comment.
I think we could remove this validation, everything depends on exoscale here, we just pass the value along. @Kidswiss what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog