Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PostgreSQL 15 and 16 on Exoscale #213

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add support for PostgreSQL 15 and 16 on Exoscale #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/exoscale/v1/dbaas_exoscale_postgresql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ type ExoscalePostgreSQLParameters struct {
type ExoscalePostgreSQLServiceSpec struct {
ExoscaleDBaaSServiceSpec `json:",inline"`

// +kubebuilder:validation:Enum="14"
// +kubebuilder:default="14"
// +kubebuilder:validation:Enum="14";"15";"16"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could remove this validation, everything depends on exoscale here, we just pass the value along. @Kidswiss what do you think?

// +kubebuilder:default="16"

// MajorVersion contains the major version for PostgreSQL.
// Currently only "14" is supported. Leave it empty to always get the latest supported version.
// Leave it empty to always get the latest supported version.
MajorVersion string `json:"majorVersion,omitempty"`

// PGSettings contains additional PostgreSQL settings.
Expand Down
6 changes: 4 additions & 2 deletions crds/exoscale.appcat.vshn.io_exoscalepostgresqls.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ spec:
description: Service contains Exoscale PostgreSQL DBaaS specific properties
properties:
majorVersion:
default: "14"
default: "16"
description: |-
MajorVersion contains the major version for PostgreSQL.
Currently only "14" is supported. Leave it empty to always get the latest supported version.
Leave it empty to always get the latest supported version.
enum:
- "14"
- "15"
- "16"
type: string
pgSettings:
description: PGSettings contains additional PostgreSQL settings.
Expand Down
Loading