Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Remove assert_object_equals. #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Aug 17, 2015

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5727

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@sideshowbarker
Copy link
Contributor Author

Need to wait for web-platform-tests/wpt#2033 to be resolved before merging this.

@johnmellor
Copy link

I've found assert_object_equals useful several times, for example:

  • comparing structured clones
  • checking that attributes exposed by an binding match an object literal with the expected values

Sometimes you do need to compare two object hierarchies, and it seems unwise to expect people to re-invent the wheel each time.

How about fixing it instead, for example #144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants