[v3 alpha] Fix drag-n-drop on some linux distros

[abichinger]

Description

On some linux distributions the cursor gets stuck when moving files over the drag-n-drop example. I haven't figured out why only some distributions are affected.

Fixes https://discord.com/channels/1042734330029547630/1220475512833441802

Changes:

• enable dnd for w.vbox instead of w.webview
• disable w.webview as a dnd destination with gtk_drag_dest_unset
  This results in events like drop and dragover to not fire at all
• Refactor: move C code

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By running the drag-n-drop example.

Because not all distributions are affected by the error, I also created a Dockerfile to reproduce the error.

FROM x11docker/gnome

RUN apt update -y -q
RUN DEBIAN_FRONTEND=noninteractive apt install -y curl git build-essential libgtk-3-dev libwebkit2gtk-4.0-dev pkg-config

RUN curl -s https://dl.google.com/go/go1.22.1.linux-amd64.tar.gz | tar -v -C /usr/local -xz
ENV PATH $PATH:/usr/local/go/bin

WORKDIR /
RUN git clone -b v3-alpha https://github.com/wailsapp/wails.git

WORKDIR /wails/v3/examples/drag-n-drop
RUN go mod tidy
RUN go build .
RUN cp ./drag-n-drop /

CMD gnome-shell

The docker image can be run with x11docker.

docker build -t drag-n-drop -f Dockerfile .
docker pull x11docker/xserver
x11docker --desktop --xc=yes --init=systemd drag-n-drop

• Windows
• macOS
• Linux

Test Configuration

# Build Environment
Wails CLI    | v3.0.0-alpha.3                          
Go Version   | go1.22.0                                
Revision     | 33946a7aace91ffb1a3992dcf3af7a2071ac70d2
Modified     | true                                    
-buildmode   | exe                                     
-compiler    | gc                                      
CGO_CFLAGS   |                                         
CGO_CPPFLAGS |                                         
CGO_CXXFLAGS |                                         
CGO_ENABLED  | 1                                       
CGO_LDFLAGS  |                                         
GOAMD64      | v1                                      
GOARCH       | amd64                                   
GOOS         | linux                                   
vcs          | git                                     
vcs.modified | true                                    
vcs.revision | 33946a7aace91ffb1a3992dcf3af7a2071ac70d2
vcs.time     | 2024-03-19T10:56:54Z                    

# System
Name         | Manjaro Linux                                                                                                 
Version      | Unknown                                                                                                       
ID           | manjaro                                                                                                       
Branding     |                                                                                                               
Platform     | linux                                                                                                         
Architecture | amd64                                                                                                         
gcc          | 13.2.1-5                                                                                                      
libgtk-3     | 1:3.24.41-1                                                                                                   
libwebkit    | 2.42.5-2                                                                                                      
npm          | 10.5.0-1                                                                                                      
pkg-config   | 2.1.0-2                                                                                                       
CPU          | AMD Ryzen 5 3600 6-Core Processor                                                                             
GPU 1        | Navi 10 [Radeon RX 5600 OEM/5600 XT / 5700/5700 XT] (Advanced Micro Devices, Inc. [AMD/ATI]) - Driver: amdgpu 
Memory       | 32GB                                                                                                          

# Diagnosis
 SUCCESS  Your system is ready for Wails development!

Checklist:

• I have updated mkdocs-website/docs/changelog.md with details of this PR
• My code follows the general coding style of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tmclane]

Can you tell me why we need to split out to the linux_cgo.h file?
There is only one file that includes it now. I don't see why that is necessary.

Will you put it back unless there is a good reason I am missing?

[abichinger]

I did it for syntax highlighting and IntelliSense. I'm happy to undo it if that's not reason enough.

[tmclane]

Let's leave it split out. Indentation is hard enough in a comment already.

FYI I couldn't get the docker image to work properly for some reason. Will try again today.

[tmclane]

I'm rescinding my request to put the code back inside the linux_cgo.go file at this time.
Doesn't seem to cause any harm.

[tmclane]

It turns out that the linux_cgo.c file is not acceptable. It causes go test errors actually.
I didn't realize that there were two new files added.

Please put the relevant code back in to the relevant sections of linux_cgo.go and remove the new linux_cgo.h and linux_cgo.c files.

[abichinger]

It turns out that the linux_cgo.c file is not acceptable. It causes go test errors actually.

Whoops, I didn't notice that. I moved the code back into linux_cgo.go

[tmclane]

Thank you!