refactor: peerManager test #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
chaitanyaprem
approved these changes
Aug 25, 2023
|
@harsh-98 Looks like tests are failing, please fix them and then we can merge this PR. |
harsh-98
force-pushed
the
peerManagertest
branch
from
0c21975
to
1ab2c0d
Compare
harsh-98
force-pushed
the
peerManagertest
branch
from
1ab2c0d
to
340da1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AddPeerToServiceSlotis exposed to prevent cyclic dependency bcz peerManager is used in test/utils for creating TestPeerDiscover and test/utils is used in test of peerManager in subfolder.Changes
Tests