Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autosharding content-topic config #696

Merged
merged 14 commits into from
Sep 6, 2023
Merged

autosharding content-topic config #696

merged 14 commits into from
Sep 6, 2023

Conversation

chaitanyaprem
Copy link
Collaborator

@chaitanyaprem chaitanyaprem commented Aug 30, 2023 •
edited
Loading

Description

New config to specify pubsub and contentTopics.
ENR updation as per config.

Changes

Tests

  • Run serviceNode by passing specific content-topic "/0/toychat/2/huilong/proto" and verified the ENR generated includes the appropriate rs value.
    enr:-Jq4QAks1JpiJ8kjKXZbUvNEjDJb5F7u1xtIyb9XXZtVEhIvHhVpDb53CQpeknyWEr5dw0U-gVFqdm-4V-blSMvAomyGAYpKuzUMgmlkgnY0gmlwhMCoAQyCcnOFAAEBAAOJc2VjcDI1NmsxoQINUHz8nP1tgbfQv4-_Aqw-enrekJpmX6u0ASpuEUPnnoN0Y3CC6mCFd2FrdTIB
  • Validate error is thrown in following scenarios
  • If topics are passed that belong to different shard cluster
  • If named and sharded topics are passed together

@status-im-auto
Copy link

status-im-auto commented Aug 30, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (48)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 481afc3 #1 2023-08-30 14:04:18 ~1 min linux 📦deb
✖️ 481afc3 #1 2023-08-30 14:04:38 ~1 min tests 📄log
✖️ 481afc3 #1 2023-08-30 14:04:39 ~1 min tests 📄log
✖️ 481afc3 #2 2023-08-30 14:05:00 ~18 sec tests 📄log
✔️ 481afc3 #2 2023-08-30 14:05:07 ~46 sec linux 📦deb
✔️ 481afc3 #1 2023-08-30 14:05:08 ~2 min nix-flake 📄log
✖️ 481afc3 #2 2023-08-30 14:05:11 ~26 sec tests 📄log
✔️ 481afc3 #2 2023-08-30 14:07:07 ~1 min nix-flake 📄log
✔️ 481afc3 #2 2023-08-30 14:08:09 ~4 min ios 📦tgz
✔️ 481afc3 #2 2023-08-30 14:09:53 ~2 min android 📦tgz
✔️ 425493c #1 2023-08-30 14:06:51 ~3 min android 📦tgz
✔️ 425493c #1 2023-08-30 14:08:09 ~5 min ios 📦tgz
✔️ 4695cb8 #3 2023-08-30 14:22:42 ~3 min linux 📦deb
✔️ 4695cb8 #3 2023-08-30 14:22:52 ~3 min ios 📦tgz
✔️ 4695cb8 #3 2023-08-30 14:23:19 ~3 min nix-flake 📄log
✔️ 4695cb8 #3 2023-08-30 14:24:27 ~5 min tests 📄log
✔️ 4695cb8 #3 2023-08-30 14:24:54 ~5 min tests 📄log
✔️ 4695cb8 #3 2023-08-30 14:25:27 ~6 min android 📦tgz
✔️ d69f8f9 #4 2023-08-31 08:51:35 ~1 min linux 📦deb
✔️ d69f8f9 #4 2023-08-31 08:52:16 ~1 min nix-flake 📄log
✔️ d69f8f9 #4 2023-08-31 08:52:23 ~1 min tests 📄log
✔️ d69f8f9 #4 2023-08-31 08:53:14 ~2 min tests 📄log
✔️ d69f8f9 #4 2023-08-31 08:53:48 ~3 min android 📦tgz
✔️ d69f8f9 #4 2023-08-31 08:54:32 ~4 min ios 📦tgz
✔️ 30c988f #5 2023-08-31 08:52:15 ~37 sec linux 📦deb
✔️ 30c988f #5 2023-08-31 08:53:47 ~1 min tests 📄log
✔️ 30c988f #5 2023-08-31 08:54:13 ~1 min nix-flake 📄log
✔️ 30c988f #5 2023-08-31 08:54:54 ~3 min ios 📦tgz
✔️ 30c988f #5 2023-08-31 08:56:22 ~3 min tests 📄log
✔️ 30c988f #5 2023-08-31 08:56:57 ~3 min android 📦tgz
✔️ 60558ff #6 2023-08-31 11:08:52 ~1 min linux 📦deb
✔️ 60558ff #6 2023-08-31 11:09:44 ~1 min nix-flake 📄log
✔️ 60558ff #6 2023-08-31 11:09:46 ~1 min tests 📄log
✔️ 60558ff #6 2023-08-31 11:12:01 ~4 min tests 📄log
✔️ 60558ff #6 2023-08-31 11:13:17 ~5 min android 📦tgz
✔️ 60558ff #6 2023-08-31 11:13:48 ~6 min ios 📦tgz
✔️ 260a174 #7 2023-09-03 23:31:40 ~31 sec linux 📦deb
✔️ 260a174 #7 2023-09-03 23:32:28 ~1 min tests 📄log
✔️ 260a174 #7 2023-09-03 23:33:01 ~1 min tests 📄log
✔️ 260a174 #7 2023-09-03 23:33:01 ~1 min nix-flake 📄log
✔️ 260a174 #7 2023-09-03 23:35:07 ~4 min android 📦tgz
✔️ 260a174 #7 2023-09-03 23:35:52 ~4 min ios 📦tgz
✔️ 57a1d68 #8 2023-09-04 08:03:38 ~32 sec linux 📦deb
✔️ 57a1d68 #8 2023-09-04 08:04:26 ~1 min tests 📄log
✔️ 57a1d68 #8 2023-09-04 08:04:54 ~1 min tests 📄log
✔️ 57a1d68 #8 2023-09-04 08:05:00 ~1 min nix-flake 📄log
✔️ 57a1d68 #8 2023-09-04 08:06:56 ~3 min ios 📦tgz
✔️ 57a1d68 #8 2023-09-04 08:07:14 ~4 min android 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e789a67 #9 2023-09-05 04:11:18 ~32 sec linux 📦deb
✔️ e789a67 #9 2023-09-05 04:12:11 ~1 min tests 📄log
✔️ e789a67 #9 2023-09-05 04:12:40 ~1 min nix-flake 📄log
✔️ e789a67 #9 2023-09-05 04:12:42 ~1 min tests 📄log
✔️ e789a67 #9 2023-09-05 04:14:32 ~3 min android 📦tgz
✔️ e789a67 #9 2023-09-05 04:15:39 ~4 min ios 📦tgz
✔️ 9dc1240 #10 2023-09-06 04:31:47 ~32 sec linux 📦deb
✔️ 9dc1240 #10 2023-09-06 04:32:00 ~46 sec tests 📄log
✔️ 9dc1240 #10 2023-09-06 04:33:07 ~1 min tests 📄log
✔️ 9dc1240 #10 2023-09-06 04:33:07 ~1 min nix-flake 📄log
✔️ 9dc1240 #10 2023-09-06 04:35:04 ~3 min android 📦tgz
✔️ 9dc1240 #10 2023-09-06 04:36:41 ~5 min ios 📦tgz

@chaitanyaprem chaitanyaprem marked this pull request as ready for review August 31, 2023 08:50
@chaitanyaprem chaitanyaprem mentioned this pull request Aug 31, 2023
Closed
5 tasks
harsh-98
harsh-98 approved these changes Aug 31, 2023
View reviewed changes
waku/v2/protocol/topic_test.go Show resolved Hide resolved
@chaitanyaprem
Copy link
Collaborator Author

@richard-ramos , in nwaku if topic validation fails the node doesn't start with an error indicating named and static shards to be not used simultaneously. But in go-waku case we seem to be proceeding ahead and just logging a warning.
Should we restrict this behaviour altogether or leave it as warning?
If the node runs like this, anyways the ENR cannot be updated and hence is not useful actually as per the user expecations right. Or is this something specially done to handle status use-cases? Require your advice on how to proceed regarding this.

@richard-ramos richard-ramos mentioned this pull request Aug 31, 2023
Merged
@richard-ramos
Copy link
Member

richard-ramos commented Aug 31, 2023 •
edited
Loading

@richard-ramos , in nwaku if topic validation fails the node doesn't start with an error indicating named and static shards to be not used simultaneously. But in go-waku case we seem to be proceeding ahead and just logging a warning.
Should we restrict this behaviour altogether or leave it as warning?

Oops! this was an oversight when I implemented that functionality. #699 fixes this, since we do need static and named shards for now in status-go

@richard-ramos
Copy link
Member

PR looks good to me.
Will chat2 be updated in this PR as well or in a separate PR?

richard-ramos
richard-ramos reviewed Sep 1, 2023
View reviewed changes
cmd/waku/node.go Outdated Show resolved Hide resolved
@chaitanyaprem
Copy link
Collaborator Author

PR looks good to me. Will chat2 be updated in this PR as well or in a separate PR?

Ah...missed compiling and updating examples. Will do that as well in this PR only.

@richard-ramos richard-ramos mentioned this pull request Sep 5, 2023
Merged
@chaitanyaprem chaitanyaprem merged commit d13b1f0 into master Sep 6, 2023
11 checks passed
@chaitanyaprem chaitanyaprem deleted the feat/autosharding-config branch September 6, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@harsh-98 harsh-98 harsh-98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaitanyaprem @status-im-auto @richard-ramos @harsh-98