fix: allow mixing named and static shards #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Jenkins BuildsClick to see older builds (7)
|
richard-ramos
force-pushed
the
fix/enr-shard
branch
from
be8b049
to
28e4494
Compare
richard-ramos
force-pushed
the
fix/enr-shard
branch
from
28e4494
to
18f6580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In status-im/status-go#3944 sharding is introduced for communities, however 1:1 and group chats use the DefaultPubsubTopic for now. In #696 (comment) @chaitanyaprem noticed that the current logic of go-waku would not set the shards if there's a mix of static and named sharding. This PR 'fixes' this problem, since currently on status-go we do have a mix of named and static shards.
Once status-go uses static sharding only, then we can remove the option to allow both static and named shards at the same time
Issue
Part of #634