Boron removal unit test harness #1415
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 94.01% 94.00% -0.02%
==========================================
Files 335 335
Lines 35572 35572
==========================================
- Hits 33444 33440 -4
- Misses 2128 2132 +4 ☔ View full report in Codecov by Sentry. |
savannahsakhai
requested review from
MarcusHolly,
hunterbarber,
ElmiraShamlou and
agarciadiego
| # Start test class | ||
| class TestBoronRemoval_GenPropPack: | ||
| @pytest.fixture(scope="class") | ||
| def gen_boron_removal_model(self): | ||
| m = ConcreteModel() | ||
| m.fs = FlowsheetBlock(dynamic=False) | ||
|
|
There was a problem hiding this comment.
Unless I missed it, this gen prop pack test is missing from the update version. Is there a reason this test should be left out?
There was a problem hiding this comment.
I had left it out initially because it had seemed redundant to test the unit model with more than 1 property model (and using a property model outside of watertap). However, if this is an important aspect for testing, I can add on these tests.
There was a problem hiding this comment.
I think it can be left out. I just wanted to make sure you had deleted it intentionally rather than accidentally leaving it out.
Fixes/Resolves:
#1302
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: