Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boron removal unit test harness #1415

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Boron removal unit test harness #1415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
794a4cf
initial save (MCAS tests only)
savannahsakhai May 14, 2024
e116b29
converted to unit test harness MCAS
savannahsakhai May 15, 2024
1bc844b
minor fixes, with test failures
savannahsakhai May 15, 2024
7b9bc22
temp save - failing pH calc and scaling
savannahsakhai May 16, 2024
f5698b2
update constraint
savannahsakhai May 17, 2024
26ddacc
update pH, failing scaling factors
savannahsakhai May 17, 2024
6e37560
bandaid fix for scaling issue in TestBoronRemoval_IonPropPack_Min
savannahsakhai May 28, 2024
94fcc9d
fix specifications TestBoronRemoval_IonPropPack_Min
savannahsakhai May 28, 2024
6901493
Merge branch 'watertap-org:main' into boron-unit-test
savannahsakhai May 30, 2024
9213c96
Merge branch 'main' into boron-unit-test
savannahsakhai May 31, 2024
9ec6d83
Merge branch 'main' into boron-unit-test
bknueven Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions watertap/unit_models/boron_removal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,6 @@ def build(self):
units=pyunits.mol / pyunits.m**3,
doc="Resulting molarity of Borate",
)

# Variables for volume and retention time
self.reactor_volume = Var(
initialize=1,
Expand Down Expand Up @@ -802,10 +801,10 @@ def initialize_build(
)

def outlet_pH(self, time=0):
return -log10(value(self.conc_mol_H[time]) / 1000)
return -log10(self.conc_mol_H[time] / (1000 * (pyunits.mol / pyunits.m**3)))

def outlet_pOH(self, time=0):
return -log10(value(self.conc_mol_OH[time]) / 1000)
return -log10(self.conc_mol_OH[time] / (1000 * (pyunits.mol / pyunits.m**3)))

def propogate_initial_state(self):
units_meta = self.config.property_package.get_metadata().get_derived_units
Expand Down
Loading