Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Google One Tap callback response error #83

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Conversation

lzdyes
Copy link
Contributor

@lzdyes lzdyes commented Jul 26, 2024

PR Checklist

What is the current behavior?

  1. fix: Calling useOneTap with this dependency package is always onError #79
  2. fix: fix: Google One Tap callback response does not contain clientId #80

What is the new behavior?

  1. Fixed the issue where it always called back to onError. Now it can successfully call back to onSuccess.
  2. I modified the CredentialResponse object definition, removed the clientId field, and added the state field. This adjustment was made based on the definition in the official Google documentation: https://developers.google.com/identity/gsi/web/reference/js-reference#CredentialResponse
  3. Fixed GoogleSignInButton.vue build type error.

@lzdyes
Copy link
Contributor Author

lzdyes commented Jul 31, 2024

@kasvith Can you take a look.

@kasvith
Copy link
Collaborator

kasvith commented Jul 31, 2024

hi yes, wait i need to update CI to run on PRs

@kasvith
Copy link
Collaborator

kasvith commented Jul 31, 2024

@lzdyes can you update your branch

@kasvith kasvith merged commit 97b9f12 into wavezync:main Aug 1, 2024
1 check passed
@kasvith
Copy link
Collaborator

kasvith commented Aug 1, 2024

all good, thanks

@lzdyes
Copy link
Contributor Author

lzdyes commented Aug 10, 2024

@kasvith Could you help release a new npm version?

@kasvith
Copy link
Collaborator

kasvith commented Aug 10, 2024

Hey sure, im afk now

Will release it today

@kasvith
Copy link
Collaborator

kasvith commented Aug 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling useOneTap with this dependency package is always onError
2 participants