Address caching issue where callback URLs aren't unique if the counter is ever reset #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver reset I have an Electron-based app which is using this to pull data from an API at regular intervals. I came across the issue where closing & reopening the app had the data being returned using the old data from the last session. Upon investigation, it appears this is due to the fact that the callback that this is implementing has a counter that is then reset when the app is restarted, and this is leading it to try and display that previously retrieved data even with Electron set to not utilize cache. The simple fix is to have it use the current timestamp rather than a session-based counter. I'd love to see this implemented in a future version as this addresses an issue I had come across that I'm thinking others might be experiencing as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an Electron-based app which is using this to pull data from an API at regular intervals. I came across the issue where closing & reopening the app had the data being returned using the old data from the last session.
Upon investigation, it appears this is due to the fact that the callback that this is implementing has a counter that is then reset when the app is restarted, and this is leading it to try and display that previously retrieved data even with Electron set to not utilize cache.
The simple fix is to have it use the current timestamp rather than a session-based counter. I'd love to see this implemented in a future version as this addresses an issue I had come across that I'm thinking others might be experiencing as well.