Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address caching issue where callback URLs aren't unique if the counter is ever reset #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Address caching issue where callback URLs aren't unique if the counter is ever reset #40

wants to merge 1 commit into from

Commits on Nov 19, 2017

  1. Address caching where callback URLs aren't unique if the counter is e… 

    …ver reset

I have an Electron-based app which is using this to pull data from an API at regular intervals. I came across the issue where closing & reopening the app had the data being returned using the old data from the last session.

Upon investigation, it appears this is due to the fact that the callback that this is implementing has a counter that is then reset when the app is restarted, and this is leading it to try and display that previously retrieved data even with Electron set to not utilize cache.

The simple fix is to have it use the current timestamp rather than a session-based counter. I'd love to see this implemented in a  future version as this addresses an issue I had come across that I'm thinking others might be experiencing as well.
    @KZeni
    KZeni authored Nov 19, 2017
    Configuration menu
    Copy the full SHA
    19f6c30 View commit details
    Browse the repository at this point in the history