-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: on_kernel_start triggers callback on virtual kernel start #471
Merged
iisakkirotko
merged 3 commits into
master
from
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
Feb 8, 2024
Merged
feat: on_kernel_start triggers callback on virtual kernel start #471
iisakkirotko
merged 3 commits into
master
from
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on Graphite |
This was referenced Jan 19, 2024
maartenbreddels
force-pushed
the
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
branch
from
January 19, 2024 19:37
6e163fd
to
0933395
Compare
iisakkirotko
force-pushed
the
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
branch
from
February 5, 2024 13:36
0933395
to
a99f167
Compare
This was referenced Feb 5, 2024
maartenbreddels
commented
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some rewording, if you agree, feel free to merge the suggestions
Co-authored-by: Maarten Breddels <[email protected]>
iisakkirotko
force-pushed
the
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
branch
from
February 8, 2024 15:32
5518aea
to
e26db2f
Compare
maartenbreddels
added a commit
that referenced
this pull request
Mar 14, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 14, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 25, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 25, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 25, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 25, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 25, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
maartenbreddels
added a commit
that referenced
this pull request
Mar 25, 2024
Introduced in #471 We should remove the on_kernel_start callbacks on a hot reload, but not remove the ones added by the hot reload itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.