Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assembly redirects for cross version integration tests #451

Closed
wants to merge 1 commit into from

Conversation

chrisbednarski
Copy link
Contributor

I encountered a few issues before I was able to build V4 and V5 test projects together.

A module merge test will follow, but I thought this might be handy in a separate commit, in case it needs to be undone for some reason later on.

  • nuget.config change loads WixToolset.* < v5 from nuget, but uses the local packages from the build folder for the v5 being built.
  • assembly redirects are required when a project references other projects with a wildcard (eg. <ProjectReference Include="**\*.wixproj" /> in TestData.proj) and some of those projects are different versions.

Before nuget.config change
unabletofindpackage

Before assembly redirects were added
cannotload1
cannotload2

@barnson
Copy link
Member

barnson commented Sep 13, 2023

FYI: This is a topic of some discussion. We need to determine (generally) how extensions are going to work in a mixed v4/v5 scenario. Please let me know if you get blocked by this and we can discuss alternatives (like temporarily committing .msis built with v4).

@chrisbednarski
Copy link
Contributor Author

Thanks. I should be ok .. I'll skip adding cross-version integration tests until a decision has been made.

@chrisbednarski
Copy link
Contributor Author

rebased with develop.
This might still provide value, pending your decision on wix versioning strategy.

My two cents:
There seems to be no harm in having this assembly redirect regardless of how the wix versioning will work in the future.

@chrisbednarski chrisbednarski deleted the feat/merge-test branch November 19, 2023 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants