gui installer: append derivation path to xpubs #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
gui-installer-append-derivation-path-to-xpubs
branch
from
4c5653a
to
cdbe1b9
Compare
|
Hmm the descriptor is trimmed when i need to back it up |
edouardparis
force-pushed
the
gui-installer-append-derivation-path-to-xpubs
branch
2 times, most recently
from
ef6c486
to
e381a7a
Compare
|
Interesting: I don't think it's a big deal nor that it should block this pull request, but i just ran into it. I think it was always possible though. |
|
I found a bug in signing a recovery transaction. I shared a screencast in private. Here is the descriptor. And here is the mnemonic And here is the PSBT |
|
Opened #584 to fix my bug. |
edouardparis
force-pushed
the
gui-installer-append-derivation-path-to-xpubs
branch
2 times, most recently
from
41aebcf
to
a43a92d
Compare
|
Merged #599, this can now be rebased. |
edouardparis
force-pushed
the
gui-installer-append-derivation-path-to-xpubs
branch
from
faddc99
to
d71be89
Compare
edouardparis
force-pushed
the
gui-installer-append-derivation-path-to-xpubs
branch
from
d71be89
to
30ce2de
Compare
|
I assume this is ready for testing? |
4 tasks
darosior
reviewed
Aug 16, 2023
There was a problem hiding this comment.
ACK 30ce2de -- tested it locally and reviewed the descriptor analysis related changes. Edouard also tested it against a setup with a Specter device.
The policy registration on the Ledger is so much cleaner.
Just a few display quirks that i think we can workaround in the future. We could regroup the "number of signatures needed" per signing device in the future so that it doesn't show "4 signatures needed from X and Y". Or "0/4" when only 2 signing devices are used. Here is what i'm talking about:
| self.edit_name = false; | ||
| } else { | ||
| self.edit_name = true; | ||
| self.form_name.value = String::new(); | ||
| } | ||
| self.form_xpub.valid = true; | ||
| self.form_xpub.valid = check_key_network(&key, self.network); |
There was a problem hiding this comment.
Wouldn't this be fixing #337 by any chance?
There was a problem hiding this comment.
yes you are right !
There was a problem hiding this comment.
Tested and i indeed can't import a testnet descriptor to mainnet anymore. Updating the OP before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT (by Antoine): this also fixes #337.