descriptors: fix analysis of missing signatures post #575 #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
fix_spend_info
branch
from
ff5c9e5
to
b1ab6ea
Compare
|
Rebased on master to fix the flaky functional test in CI. |
edouardparis
reviewed
Aug 9, 2023
darosior
force-pushed
the
fix_spend_info
branch
from
b1ab6ea
to
f92b454
Compare
It's supposed to represent the number of signature per "master" key, i guess. At the moment it would always be 1 because the origin changes when we queried more keys from the signing device (because we increased the account).
darosior
force-pushed
the
fix_spend_info
branch
from
f92b454
to
b76faf4
Compare
|
Addressed @edouardparis's review comments and rebased on master. |
Since wizardsardine#575 we started using xpubs with an appended derivation path, and the analysis was assuming there wasn't any.
darosior
force-pushed
the
fix_spend_info
branch
from
b76faf4
to
10acc48
Compare
|
Reverted the change that broke the MSRV. |
|
ACK 10acc48 -- Edouard ACK'd the child PR at #599 (review) |
darosior
added a commit
that referenced
this pull request
Aug 11, 2023
…m `<0;1>` 605c3f6 descriptors: allow the multipath step to be different than '<0;1>' (Antoine Poinsot) Pull request description: Ledger and wallet policies disallow having more than 2 depth after the placeholder, therefore we can't do `@1/0/<0;1>/*`, `@1/1/<0;1>/*`, .. Instead we have to do `@1/<0;1>/*`, `@1/<2;3>/*`, .. Why not? Salvatore also says the cost of deriving another depth is non-trivial on a signing device. Don't pick a fight with Salvatore, instead just let the GUI (or whatever creates the desc) use different multipath steps for keys derived from the same xpubs. Based on #584. We need to make sure we don't make the assumptions of the multipath step always being `<0;1>` anywhere else the codebase. ACKs for top commit: edouardparis: ACK 605c3f6 Tree-SHA512: acccc31730057a59cf0caccfb258c7b3ea2c27e4181636405e23b974952d6832b45a07f3ba9d627e09c3e9b58ab2d2ab95ba4a6d3c4f3d970f56cad981fa4aaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more testing but that should do the trick: we need to take into account the derivation path appended to the xpub in addition to the one from the origin!