Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tempo/2.6.0 package update #27460

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Sep 3, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Sep 3, 2024
Copy link
Contributor Author

octo-sts bot commented Sep 3, 2024

Open AI suggestions to solve the build error:

The error message is: 

"fatal: detected dubious ownership in repository at '/github/home'
To add an exception for this directory, call:

git config --global --add safe.directory /github/home
ERRO request failed error="Get \"./packages/apk-configuration\": unsupported protocol scheme \"\"" method=GET url=./packages/apk-configuration
ERRO ERROR: failed to build package. the build environment has been preserved:
INFO workspace dir: /temp/melange-workspace-3848893503
INFO guest dir: /temp/melange-guest-345064426
ERRO failed to build package: unable to run package tempo pipeline: unable to run pipeline: unable to run pipeline: exit status 1
make[1]: *** [Makefile:111: packages/aarch64/tempo-2.6.0-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/tempo] Error 2"


To fix this error:
1. Run `git config --global --add safe.directory /github/home`.
2. Ensure the URL in the GET request for `./packages/apk-configuration` uses a supported protocol (e.g., `http://` or `https://`).
3. Verify the build environment and dependencies.
4. Re-run the build process.

@mamccorm
Copy link
Member

Patch now included upstream in latest release:

Removing our own patch

Copy link
Contributor Author

octo-sts bot commented Sep 11, 2024

Open AI suggestions to solve the build error:

The error message is: "ERROR: failed to build package. the build environment has been preserved:
INFO   workspace dir: /temp/melange-workspace-1540086453
INFO   guest dir: /temp/melange-guest-262290182
ERRO failed to build package: unable to run package tempo pipeline: unable to run pipeline: exit status 2
make[1]: *** [Makefile:111: packages/aarch64/tempo-2.6.0-r0.apk] Error 1
make[1]: Leaving directory '/github/home'
make: *** [Makefile:101: package/tempo] Error 2
##[error]Process completed with exit code 2."

1. Check the Makefile at line 111 for errors in the build command for `tempo-2.6.0-r0.apk`.
2. Ensure all dependencies for the build are installed.
3. Verify the build environment paths `/temp/melange-workspace-1540086453` and `/temp/melange-guest-262290182` are correct.
4. Run the build command manually to see detailed error output.
5. Check for any missing or incorrect environment variables.

Becasue of a known-issue with go1.23:
grafana/tempo#4086

Signed-off-by: Dentrax <[email protected]>
@Dentrax
Copy link
Member

Dentrax commented Oct 6, 2024

The build issue because of a known-issue: grafana/tempo#4086 (comment)

I able to "fix" it by a workaround:

  - uses: go/bump
    with:
      deps: github.com/grafana/pyroscope-go/[email protected]
      replaces: github.com/grafana/pyroscope-go/godeltaprof=github.com/grafana/pyroscope-go/[email protected]

But it seems there are other go1.23 related issues: grafana/tempo#4006

FWIW, Tempo v2.6.0 shouldn't ship with go1.23 until they cut a new release.

So, used go1.22 in the build-time deps for now.

This PR also deprecates: #28859

Copy link
Contributor

github-actions bot commented Oct 6, 2024

Package tempo: Click to expand/collapse

Package tempo:
Modified: /usr/bin/tempo

Package tempo-cli: Click to expand/collapse

Package tempo-cli:
Modified: /usr/bin/tempo-cli

Package tempo-query: Click to expand/collapse

Package tempo-query:
Modified: /usr/bin/tempo-query

Package tempo-vulture: Click to expand/collapse

Package tempo-vulture:
Modified: /usr/bin/tempo-vulture

malcontent found differences: Click to expand/collapse

Deleted: tempo-cli/var/lib/db/sbom/tempo-cli-2.5.0-r5.spdx.json [⚠️ MEDIUM]

RISK KEY DESCRIPTION EVIDENCE
-MEDIUM net/download download files downloadLocation
-LOW ref/site/url contains embedded HTTPS URLs https://spdx.org/spdxdocs/chainguard/melange/dbf99197f96c2b63c0df62a038c3

Deleted: tempo-query/var/lib/db/sbom/tempo-query-2.5.0-r5.spdx.json [⚠️ MEDIUM]

RISK KEY DESCRIPTION EVIDENCE
-MEDIUM net/download download files downloadLocation
-LOW ref/site/url contains embedded HTTPS URLs https://spdx.org/spdxdocs/chainguard/melange/b7f3eec792fa09c99c8400c0e2d3

Deleted: tempo-vulture/var/lib/db/sbom/tempo-vulture-2.5.0-r5.spdx.json [⚠️ MEDIUM]

RISK KEY DESCRIPTION EVIDENCE
-MEDIUM net/download download files downloadLocation
-LOW ref/site/url contains embedded HTTPS URLs https://spdx.org/spdxdocs/chainguard/melange/f2d1e2c93254bd2124c347c66268

Added: tempo-cli/var/lib/db/sbom/tempo-cli-2.6.0-r0.spdx.json [⚠️ MEDIUM]

RISK KEY DESCRIPTION EVIDENCE
+MEDIUM net/download download files downloadLocation
+LOW ref/site/url contains embedded HTTPS URLs https://spdx.org/spdxdocs/chainguard/melange/27d62833e25af90e9519baed9db7

Added: tempo-query/var/lib/db/sbom/tempo-query-2.6.0-r0.spdx.json [⚠️ MEDIUM]

RISK KEY DESCRIPTION EVIDENCE
+MEDIUM net/download download files downloadLocation
+LOW ref/site/url contains embedded HTTPS URLs https://spdx.org/spdxdocs/chainguard/melange/8a89529da7b0e47e10ea3f6a5af0

Added: tempo-vulture/var/lib/db/sbom/tempo-vulture-2.6.0-r0.spdx.json [⚠️ MEDIUM]

RISK KEY DESCRIPTION EVIDENCE
+MEDIUM net/download download files downloadLocation
+LOW ref/site/url contains embedded HTTPS URLs https://spdx.org/spdxdocs/chainguard/melange/63c632c737c4a95bdff67894f4eb

Moved: tempo/var/lib/db/sbom/tempo-2.5.0-r5.spdx.json -> /tmp/wolfictl-apk-870124253/tempo/var/lib/db/sbom/tempo-2.6.0-r0.spdx.json (similarity: 0.97)

@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Oct 6, 2024
@rawlingsj rawlingsj merged commit 57c6062 into main Oct 7, 2024
14 checks passed
@rawlingsj rawlingsj deleted the wolfictl-2fbb41df-706f-4e91-95ca-3323c24b6363 branch October 7, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants