Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpunit polyfills to 1.1 #333

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

jorgemd24
Copy link
Contributor

@jorgemd24 jorgemd24 commented Nov 24, 2023

Changes proposed in this Pull Request:

See https://github.com/woocommerce/automatewoo/pull/1626

This extension was not updated yet.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots:

Detailed test instructions:

  1. Confirm all the unit test pass in this PR for all versions of WP.

Additional details:

Command run to update the package: composer require --dev yoast/phpunit-polyfills:"^1.1.0" && composer install

Changelog entry

Dev - Update phpunit polyfills to 1.1 for WP 6.4

@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Nov 24, 2023
@jorgemd24 jorgemd24 self-assigned this Nov 24, 2023
@jorgemd24 jorgemd24 requested a review from a team November 24, 2023 13:15
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jorgemd24,

Thanks for the update! Tested locally and all tests are passing so LGTM ✅

@jorgemd24 jorgemd24 merged commit 65ce7f8 into trunk Nov 24, 2023
6 checks passed
@jorgemd24 jorgemd24 deleted the tweak/update-phpunit-polyfills branch November 24, 2023 17:30
@tomalec tomalec mentioned this pull request Nov 28, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants