[MVC 구현하기 - 3단계] 짱수(장혁수) 미션 제출합니다. #840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwax1324
requested changes
Oct 2, 2024
mvc/src/test/java/com/interface21/webmvc/servlet/mvc/framework/DispatcherServletTest.java
Show resolved
Hide resolved
mvc/src/main/java/com/interface21/webmvc/servlet/view/JsonView.java
Outdated
Show resolved
Hide resolved
dwax1324
requested changes
Oct 8, 2024
|
|
||
| @RequestMapping(value = "/api/user", method = RequestMethod.GET) | ||
| public ModelAndView show(HttpServletRequest request, HttpServletResponse response) { | ||
| final String account = request.getParameter("account"); |
There was a problem hiding this comment.
"account" parameter가 2개 이상이면 어떻게 될까요?🤔
| log.debug("Method : {}, Request URI : {}", request.getMethod(), requestURI); | ||
|
|
||
| try { | ||
| HandlerAdapter handlerAdapter = getHandlerAdapter(request); |
| HandlerAdapter handlerAdapter = getHandlerAdapter(request); | ||
| ModelAndView modelAndView = handlerAdapter.handle(request, response); | ||
| modelAndView.getView().render(modelAndView.getModel(), request, response); | ||
| } catch (Throwable e) { |
There was a problem hiding this comment.
Exception, Error, Throwable 의 차이에 대해 알고 계신가요??
| .map(handlerMappingAdapter -> handlerMappingAdapter.getHandler(request)) | ||
| .filter(Objects::nonNull) | ||
| .findFirst() | ||
| .orElseThrow(() -> new NoMatchedHandlerException(request)); |
There was a problem hiding this comment.
처리할 핸들러가 없을 때 상태코드 500와 에러페이지를 보여 주고 있습니다.
사용자가 알 수 있도록 올바른 상태코드와 페이지를 보여주는 것이 어떨까요?
| JspView view = UserSession.getUserFrom(req.getSession()) | ||
| .map(user -> { | ||
| log.info("logged in {}", user.getAccount()); | ||
| return new JspView("redirect:/index.jsp"); |
There was a problem hiding this comment.
JspView이름에서 충분히 유추 가능하기 때문에 �확장자까지 주입할 필요는 없을거 같아요!
Comment on lines
+36
to
+39
| String key = model.keySet().stream() | ||
| .findFirst() | ||
| .get(); | ||
| return objectMapper.writeValueAsString(model.get(key)); |
Comment on lines
+33
to
+37
| handlerMappingAdapters = Stream.of(new AnnotationHandlerMappingAdapter(basePackage)) | ||
| .map(adapter -> { | ||
| adapter.initialize(); | ||
| return (HandlerMappingAdapter) adapter; | ||
| }).toList(); |
There was a problem hiding this comment.
handlerMappingAdapters = Stream.of(new AnnotationHandlerMappingAdapter(basePackage))
.peek(AnnotationHandlerMappingAdapter::initialize)
.map(adapter -> (HandlerMappingAdapter) adapter)
.toList();
요렇게 표현해볼 수도 있을 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
종이, 안녕하세요!
마지막 미션 제출이네요!!!
files changed 가 조금 많이 잡혔는데, 패키지 이동, 파일 삭제가 많아서 그렇습니다...ㅎㅎ
이번 리뷰도 잘 부탁드려요!!!!