-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MVC 구현하기 - 3단계] 짱수(장혁수) 미션 제출합니다. #840
Open
zangsu
wants to merge
17
commits into
woowacourse:zangsu
Choose a base branch
from
zangsu:step3
base: zangsu
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d983eb8
feat: JsonView 구현
zangsu 538ed8b
refactor: 모든 controller 를 어노테이션 기반으로 변경
zangsu 61e8883
chore: 사용하지 않는 레거시 코드 삭제
zangsu 44d1771
feat: 유저 정보 조회 기능 추가
zangsu f95547c
chore: tobe 패키지 삭제
zangsu 457420f
refactor: model 이 하나인 경우에 대한 검증 추가
zangsu 273ad5f
style: dependency 를 정렬
zangsu 047876d
refactor: DispatcherServlet 이 포함할 패키지 명시
zangsu c6487f1
test: DispatcherServlet 이 테스트용 패키지를 사용하도록 변경
zangsu b1ed677
refactor: 미디어 타입을 정해진 상수를 사용하도록 변경
zangsu 6cdd040
study: stage3 완료
zangsu 3d40a74
style: 코드 스타일 재설정
zangsu 7ca2947
refactor: Stream 을 사용해 HandlerMappingAdapter 생성부터 초기화까지의 과정을 한번에 진행하도…
zangsu f447f51
refactor: 요청을 처리할 수 있는 HandlerAdapter 를 조회하는 부분을 메서드 분리
zangsu 4144e07
docs: 처리한 부분에 대한 todo 제거
zangsu dc16972
refactor: 필드 접근 제어자 중복 설정 제거
zangsu 09adbde
study: stage4 완료
zangsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
app/src/main/java/com/techcourse/controller/ForwardController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package com.techcourse.controller; | ||
|
||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
|
||
import com.interface21.context.stereotype.Controller; | ||
import com.interface21.web.bind.annotation.RequestMapping; | ||
import com.interface21.web.bind.annotation.RequestMethod; | ||
import com.interface21.webmvc.servlet.ModelAndView; | ||
import com.interface21.webmvc.servlet.view.JspView; | ||
|
||
@Controller | ||
public class ForwardController { | ||
|
||
@RequestMapping(value = "/", method = RequestMethod.GET) | ||
public ModelAndView index(HttpServletRequest request, HttpServletResponse response) { | ||
return new ModelAndView(new JspView("/index.jsp")); | ||
} | ||
} |
40 changes: 29 additions & 11 deletions
40
app/src/main/java/com/techcourse/controller/LoginController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,55 @@ | ||
package com.techcourse.controller; | ||
|
||
import com.techcourse.domain.User; | ||
import com.techcourse.repository.InMemoryUserRepository; | ||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
import com.interface21.webmvc.servlet.mvc.asis.Controller; | ||
|
||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
public class LoginController implements Controller { | ||
import com.interface21.context.stereotype.Controller; | ||
import com.interface21.web.bind.annotation.RequestMapping; | ||
import com.interface21.web.bind.annotation.RequestMethod; | ||
import com.interface21.webmvc.servlet.ModelAndView; | ||
import com.interface21.webmvc.servlet.view.JspView; | ||
import com.techcourse.domain.User; | ||
import com.techcourse.repository.InMemoryUserRepository; | ||
|
||
@Controller | ||
public class LoginController { | ||
|
||
private static final Logger log = LoggerFactory.getLogger(LoginController.class); | ||
|
||
@Override | ||
public String execute(final HttpServletRequest req, final HttpServletResponse res) throws Exception { | ||
@RequestMapping(value = "/login", method = RequestMethod.POST) | ||
public ModelAndView save(HttpServletRequest req, HttpServletResponse res) { | ||
if (UserSession.isLoggedIn(req.getSession())) { | ||
return "redirect:/index.jsp"; | ||
return new ModelAndView(new JspView("redirect:/index.jsp")); | ||
} | ||
|
||
return InMemoryUserRepository.findByAccount(req.getParameter("account")) | ||
.map(user -> { | ||
log.info("User : {}", user); | ||
return login(req, user); | ||
}) | ||
.orElse("redirect:/401.jsp"); | ||
.orElse(new ModelAndView(new JspView("redirect:/401.jsp"))); | ||
} | ||
|
||
private String login(final HttpServletRequest request, final User user) { | ||
private ModelAndView login(final HttpServletRequest request, final User user) { | ||
if (user.checkPassword(request.getParameter("password"))) { | ||
final var session = request.getSession(); | ||
session.setAttribute(UserSession.SESSION_KEY, user); | ||
return "redirect:/index.jsp"; | ||
return new ModelAndView(new JspView("redirect:/index.jsp")); | ||
} | ||
return "redirect:/401.jsp"; | ||
return new ModelAndView(new JspView("redirect:/401.jsp")); | ||
} | ||
|
||
@RequestMapping(value = "/login/view", method = RequestMethod.GET) | ||
public ModelAndView show(HttpServletRequest req, HttpServletResponse res) { | ||
JspView view = UserSession.getUserFrom(req.getSession()) | ||
.map(user -> { | ||
log.info("logged in {}", user.getAccount()); | ||
return new JspView("redirect:/index.jsp"); | ||
}) | ||
.orElse(new JspView("/login.jsp")); | ||
return new ModelAndView(view); | ||
} | ||
} |
22 changes: 0 additions & 22 deletions
22
app/src/main/java/com/techcourse/controller/LoginViewController.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
app/src/main/java/com/techcourse/controller/UserController.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package com.techcourse.controller; | ||
|
||
|
||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
|
||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
import com.interface21.context.stereotype.Controller; | ||
import com.interface21.web.bind.annotation.RequestMapping; | ||
import com.interface21.web.bind.annotation.RequestMethod; | ||
import com.interface21.webmvc.servlet.ModelAndView; | ||
import com.interface21.webmvc.servlet.view.JsonView; | ||
import com.techcourse.domain.User; | ||
import com.techcourse.repository.InMemoryUserRepository; | ||
|
||
@Controller | ||
public class UserController { | ||
|
||
private static final Logger log = LoggerFactory.getLogger(UserController.class); | ||
|
||
@RequestMapping(value = "/api/user", method = RequestMethod.GET) | ||
dwax1324 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public ModelAndView show(HttpServletRequest request, HttpServletResponse response) { | ||
final String account = request.getParameter("account"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "account" parameter가 2개 이상이면 어떻게 될까요?🤔 |
||
log.debug("user id : {}", account); | ||
|
||
final ModelAndView modelAndView = new ModelAndView(new JsonView()); | ||
final User user = InMemoryUserRepository.findByAccount(account) | ||
.orElseThrow(); | ||
|
||
modelAndView.addObject("user", user); | ||
return modelAndView; | ||
} | ||
} |
60 changes: 0 additions & 60 deletions
60
app/src/main/java/com/techcourse/framework/DispatcherServlet.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 0 additions & 24 deletions
24
app/src/main/java/com/techcourse/framework/ManualHandler/ManualHandlerAdapter.java
This file was deleted.
Oops, something went wrong.
33 changes: 0 additions & 33 deletions
33
app/src/main/java/com/techcourse/framework/ManualHandler/ManualHandlerMapping.java
This file was deleted.
Oops, something went wrong.
31 changes: 0 additions & 31 deletions
31
app/src/main/java/com/techcourse/framework/ManualHandler/ManualHandlerMappingAdapter.java
This file was deleted.
Oops, something went wrong.
49 changes: 49 additions & 0 deletions
49
app/src/test/java/com/techcourse/controller/UserControllerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
package com.techcourse.controller; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.when; | ||
|
||
import java.io.IOException; | ||
import java.io.PrintWriter; | ||
import java.io.StringWriter; | ||
|
||
import jakarta.servlet.ServletException; | ||
import jakarta.servlet.http.HttpServletRequest; | ||
import jakarta.servlet.http.HttpServletResponse; | ||
|
||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import com.fasterxml.jackson.databind.ObjectMapper; | ||
import com.interface21.webmvc.servlet.mvc.framework.DispatcherServlet; | ||
import com.techcourse.repository.InMemoryUserRepository; | ||
|
||
class UserControllerTest { | ||
dwax1324 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
DispatcherServlet dispatcherServlet = new DispatcherServlet("com.techcourse.controller"); | ||
|
||
@BeforeEach | ||
void init() { | ||
dispatcherServlet.init(); | ||
} | ||
|
||
@Test | ||
void test() throws IOException, ServletException { | ||
HttpServletRequest request = mock(HttpServletRequest.class); | ||
HttpServletResponse response = mock(HttpServletResponse.class); | ||
StringWriter stringWriter = new StringWriter(); | ||
|
||
when(request.getRequestURI()).thenReturn("/api/user"); | ||
when(request.getMethod()).thenReturn("GET"); | ||
when(request.getParameter("account")).thenReturn("gugu"); | ||
when(response.getWriter()).thenReturn(new PrintWriter(stringWriter)); | ||
|
||
dispatcherServlet.service(request, response); | ||
|
||
assertThat(stringWriter.toString()).isEqualTo( | ||
new ObjectMapper().writeValueAsString( | ||
InMemoryUserRepository.findByAccount("gugu").get() | ||
)); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JspView
이름에서 충분히 유추 가능하기 때문에 �확장자까지 주입할 필요는 없을거 같아요!