Remove readerTabViewController

wordpress-mobile · Sep 16, 2024 · df6b060 · df6b060
1 parent dca86e8
commit df6b060
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 26 deletions.
diff --git a/WordPress/Classes/System/MySitesCoordinator+RootViewPresenter.swift b/WordPress/Classes/System/MySitesCoordinator+RootViewPresenter.swift
@@ -16,11 +16,6 @@ extension MySitesCoordinator: RootViewPresenter {
 
     // MARK: Reader
 
-    var readerTabViewController: ReaderTabViewController? {
-        unsupportedFeatureFallback()
-        return nil
-    }
-
     var readerCoordinator: ReaderCoordinator? {
         unsupportedFeatureFallback()
         return nil

diff --git a/WordPress/Classes/System/RootViewPresenter.swift b/WordPress/Classes/System/RootViewPresenter.swift
@@ -11,7 +11,6 @@ protocol RootViewPresenter: AnyObject {
 
     // MARK: Reader
 
-    var readerTabViewController: ReaderTabViewController? { get }
     var readerCoordinator: ReaderCoordinator? { get }
     var readerNavigationController: UINavigationController? { get }
     func showReaderTab()

diff --git a/WordPress/Classes/System/SplitViewRootPresenter.swift b/WordPress/Classes/System/SplitViewRootPresenter.swift
@@ -266,8 +266,6 @@ final class SplitViewRootPresenter: RootViewPresenter {
         return siteContent?.blog
     }
 
-    var readerTabViewController: ReaderTabViewController?
-
     var readerCoordinator: ReaderCoordinator? {
         ReaderCoordinator()
     }

diff --git a/WordPress/Classes/System/StaticScreensTabBarWrapper.swift b/WordPress/Classes/System/StaticScreensTabBarWrapper.swift
@@ -29,10 +29,6 @@ class StaticScreensTabBarWrapper: RootViewPresenter {
 
     // MARK: Reader
 
-    var readerTabViewController: ReaderTabViewController? {
-        return nil
-    }
-
     var readerCoordinator: ReaderCoordinator? {
         return nil
     }

diff --git a/WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabViewController.swift b/WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabViewController.swift
@@ -93,12 +93,6 @@ class ReaderTabViewController: UIViewController {
         ReaderTracker.shared.start(.main)
     }
 
-    func presentDiscoverTab() {
-        viewModel.fetchReaderMenu()
-        viewModel.showTab(at: ReaderTabConstants.discoverIndex)
-        displayNotice(title: NSLocalizedString("Comment to start making connections.", comment: "Hint for users to grow their audience by commenting on other blogs."))
-    }
-
     // MARK: - Reader FAB
 
     private func createFABIfNeeded() {

diff --git a/...ss/Classes/ViewRelated/Reader/Tab Navigation/WPTabBarController+ReaderTabNavigation.swift b/...ss/Classes/ViewRelated/Reader/Tab Navigation/WPTabBarController+ReaderTabNavigation.swift
@@ -5,10 +5,6 @@ protocol ReaderContentViewController: UIViewController {
 
 // MARK: - Reader Factory
 extension WPTabBarController {
-    var readerTabViewController: ReaderTabViewController? {
-        readerNavigationController?.topViewController as? ReaderTabViewController
-    }
-
     @objc func makeReaderTabViewController() -> ReaderTabViewController {
         return ReaderTabViewController(viewModel: readerTabViewModel) { [weak self] viewModel in
             guard let self else {

diff --git a/WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift b/WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift
@@ -524,10 +524,9 @@ extension SiteStatsInsightsTableViewController: SiteStatsInsightsDelegate {
             }
 
             self.navigationController?.popToRootViewController(animated: false)
-            RootViewCoordinator.sharedPresenter.showReaderTab()
-            if let vc = RootViewCoordinator.sharedPresenter.readerTabViewController {
-                vc.presentDiscoverTab()
-            }
+            RootViewCoordinator.sharedPresenter.switchToDiscover()
+
+            Notice(title: NSLocalizedString("Comment to start making connections.", comment: "Hint for users to grow their audience by commenting on other blogs.")).post()
         }
 
         let nc = UINavigationController(rootViewController: vc)